Add support for LIVISI climate devices#86691
Merged
epenet merged 14 commits intoFeb 27, 2023
Merged
Conversation
Merged
8 tasks
epenet
reviewed
Jan 26, 2023
2fcded7 to
3c7c2db
Compare
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
9bf6d90 to
2a1a5e5
Compare
epenet
reviewed
Feb 27, 2023
epenet
requested changes
Feb 27, 2023
Contributor
epenet
left a comment
There was a problem hiding this comment.
LGTM 👍
One small tweak regarding class attributes.
Then in a follow-up PR I suggest that you create a base LivisiEntity to merge some of the behavior from switch and climate.
epenet
reviewed
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
All support for LIVISI climate devices.
Implement reauthentication flow.
Type of change
Additional information
Aio livisi: https://github.com/StefanIacobLivisi/aiolivisi
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: