Skip to content

Add support for LIVISI climate devices#86691

Merged
epenet merged 14 commits into
home-assistant:devfrom
StefanIacobLivisi:livisi-climate-integration
Feb 27, 2023
Merged

Add support for LIVISI climate devices#86691
epenet merged 14 commits into
home-assistant:devfrom
StefanIacobLivisi:livisi-climate-integration

Conversation

@StefanIacobLivisi
Copy link
Copy Markdown
Contributor

@StefanIacobLivisi StefanIacobLivisi commented Jan 26, 2023

Proposed change

All support for LIVISI climate devices.
Implement reauthentication flow.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Aio livisi: https://github.com/StefanIacobLivisi/aiolivisi

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this into three separate PRs:

  • dependency bump (please also ensure that you add tags to the repository when you build a release)
  • implement reauth
  • add climate platform

Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested above

@StefanIacobLivisi StefanIacobLivisi force-pushed the livisi-climate-integration branch from 2fcded7 to 3c7c2db Compare January 26, 2023 13:56
@StefanIacobLivisi StefanIacobLivisi changed the title Add support for LIVISI climate devices, add reauthentication flow Add support for LIVISI climate devices Jan 26, 2023
@epenet epenet marked this pull request as draft January 26, 2023 15:03
@home-assistant home-assistant Bot marked this pull request as draft February 24, 2023 16:56
@StefanIacobLivisi StefanIacobLivisi force-pushed the livisi-climate-integration branch from 9bf6d90 to 2a1a5e5 Compare February 27, 2023 07:51
@StefanIacobLivisi StefanIacobLivisi marked this pull request as ready for review February 27, 2023 07:54
@home-assistant home-assistant Bot requested a review from epenet February 27, 2023 07:54
@StefanIacobLivisi StefanIacobLivisi requested review from epenet and removed request for epenet February 27, 2023 07:54
Comment thread homeassistant/components/livisi/climate.py
Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
One small tweak regarding class attributes.
Then in a follow-up PR I suggest that you create a base LivisiEntity to merge some of the behavior from switch and climate.

Comment thread homeassistant/components/livisi/climate.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft February 27, 2023 08:22
Comment thread .coveragerc
@StefanIacobLivisi StefanIacobLivisi marked this pull request as ready for review February 27, 2023 08:42
Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epenet epenet merged commit 10bf910 into home-assistant:dev Feb 27, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 28, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed integration: livisi new-feature new-platform noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: No score

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants