Skip to content

Add ppb to voc#25768

Closed
elupus wants to merge 1 commit into
home-assistant:currentfrom
elupus:voc_ppb
Closed

Add ppb to voc#25768
elupus wants to merge 1 commit into
home-assistant:currentfrom
elupus:voc_ppb

Conversation

@elupus
Copy link
Copy Markdown
Contributor

@elupus elupus commented Jan 15, 2023

Proposed change

Allow ppb as a voc value.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@elupus elupus requested a review from a team as a code owner January 15, 2023 20:02
@home-assistant home-assistant Bot added current This PR goes into the current branch has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 15, 2023
@home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is targeting an incorrect branch. It depends on a PR in core and thus needs to be targeting the next branch.

Please change the target branch and git rebase your changes if needed.

../Frenck

@elupus
Copy link
Copy Markdown
Contributor Author

elupus commented Jan 15, 2023

It was correct when i opened it as a bug fix. Since you don't want to see it as a bug fix i'll retarget.

@elupus elupus closed this Jan 15, 2023
@home-assistant home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Jan 15, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants