Add ppb to allowed VOC values#85964
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
frenck
left a comment
There was a problem hiding this comment.
Additions of units has been flowing through the architecture repository. Please create an discussion there and provide an overview of the use.
Thanks 👍
../Frenck
|
I'm not against it, but needs adjustments in:
I also suggest that you look for original arch discussion around the device class to see if there was a reason to exclude. |
|
Removed the milestone as per above. |
| SensorDeviceClass.VOLATILE_ORGANIC_COMPOUNDS: { | ||
| CONCENTRATION_MICROGRAMS_PER_CUBIC_METER | ||
| CONCENTRATION_MICROGRAMS_PER_CUBIC_METER, | ||
| CONCENTRATION_PARTS_PER_MILLION, |
There was a problem hiding this comment.
ppb is parts per billion, not million. Is this intentional?
There was a problem hiding this comment.
Not really. But this pull is going no where. A new device class needs to be added.
Proposed change
Allow PPB as VOC unit.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: