Skip to content

Update ISY994 documentation to be model agnostic#25514

Merged
frenck merged 2 commits into
home-assistant:nextfrom
shbatm:isy994_title_change
Jan 3, 2023
Merged

Update ISY994 documentation to be model agnostic#25514
frenck merged 2 commits into
home-assistant:nextfrom
shbatm:isy994_title_change

Conversation

@shbatm
Copy link
Copy Markdown
Contributor

@shbatm shbatm commented Jan 2, 2023

Proposed change

Revises the isy994 integration to be more agnostic to specific UDI model numbers. The "ISY" term is now more broadly associated with Universal Devices' software rather than the legacy ISY994 device. They have also introduced the IoX term to refer to ISY-on-Anything firmware, which runs the control software on their newer Polisy and eisy devices.

  1. Change Title from "Universal Devices ISY994" to "Universal Devices ISY/IoX" to reflect new UDI naming.
  2. Generalize "ISY994" to "ISY" where referring to the software and not the specific model number.

At this point, I don't believe it's worth the hassle of changing the integration domain from isy994, simply to avoid breaking changes, but this will help users understand that the integration is for the full ISY family, not just the ISY994 device.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Jan 2, 2023
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Jan 2, 2023

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 2, 2023
@shbatm shbatm marked this pull request as ready for review January 2, 2023 23:44
@shbatm shbatm requested a review from bdraco as a code owner January 2, 2023 23:44
@bdraco bdraco added parent-merged The parent PR has been merged already and removed in-progress This PR/Issue is currently being worked on labels Jan 3, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shbatm 👍

Happy New Year 🥂

../Frenck

@frenck frenck merged commit e6e2fd9 into home-assistant:next Jan 3, 2023
@home-assistant home-assistant Bot removed the parent-merged The parent PR has been merged already label Jan 3, 2023
@shbatm shbatm deleted the isy994_title_change branch January 3, 2023 16:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants