Skip to content

Update ISY994 integration to be model agnostic#85017

Merged
bdraco merged 3 commits into
home-assistant:devfrom
shbatm:isy994_title_change
Jan 3, 2023
Merged

Update ISY994 integration to be model agnostic#85017
bdraco merged 3 commits into
home-assistant:devfrom
shbatm:isy994_title_change

Conversation

@shbatm
Copy link
Copy Markdown
Contributor

@shbatm shbatm commented Jan 2, 2023

Proposed change

Revises the isy994 integration to be more agnostic to specific UDI model numbers. The "ISY" term is now more broadly associated with Universal Devices' software rather than the legacy ISY994 device. They have also introduced the IoX term to refer to ISY-on-Anything firmware, which runs the control software on their newer Polisy and eisy devices.

  1. Change Title from "Universal Devices ISY994" to "Universal Devices ISY/IoX" to reflect new UDI naming.
  2. Generalize "ISY994" to "ISY/IoX" where referring to the software and not the specific model number.

At this point, I don't believe it's worth the hassle of changing the integration domain from isy994, simply to avoid breaking changes, but this will help users understand that the integration is for the full ISY family, not just the ISY994 device.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jan 2, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (isy994) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of isy994 can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign isy994 Removes the current integration label and assignees on the issue, add the integration domain after the command.

Comment thread homeassistant/components/isy994/translations/cs.json
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jan 2, 2023

Testing this now

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shbatm

@bdraco bdraco merged commit 240e1fd into home-assistant:dev Jan 3, 2023
@shbatm shbatm deleted the isy994_title_change branch January 3, 2023 03:34
mkmer pushed a commit to mkmer/HomeAssistant_Core that referenced this pull request Jan 3, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants