Add Ukraine Alert: Air-raid sirens in Ukraine integration#22672
Merged
balloob merged 3 commits intohome-assistant:nextfrom May 8, 2022
Merged
Add Ukraine Alert: Air-raid sirens in Ukraine integration#22672balloob merged 3 commits intohome-assistant:nextfrom
balloob merged 3 commits intohome-assistant:nextfrom
Conversation
probot-home-assistant
Bot
added
in-progress
|
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
11 tasks
probot-home-assistant
Bot
added
the
has-parent
22 tasks
balloob
reviewed
May 8, 2022
Comment on lines
+17
to
+24
| The Ukraine Alarm integration uses the [Ukraine Alarm](https://www.ukrainealarm.com/) web service as a source for air-raid sirens in Ukraine for your region. It's became very important since [Russian troops invasion](https://war.ukraine.ua/). | ||
|
|
||
| For each region integration exposes 4 binary sensors: | ||
|
|
||
| - Air | ||
| - Unknown | ||
| - Artillery | ||
| - Urban Fights |
Member
There was a problem hiding this comment.
Suggested change
| The Ukraine Alarm integration uses the [Ukraine Alarm](https://www.ukrainealarm.com/) web service as a source for air-raid sirens in Ukraine for your region. It's became very important since [Russian troops invasion](https://war.ukraine.ua/). | |
| For each region integration exposes 4 binary sensors: | |
| - Air | |
| - Unknown | |
| - Artillery | |
| - Urban Fights | |
| The Ukraine Alarm integration uses the [Ukraine Alarm](https://www.ukrainealarm.com/) web service to offer alerts. The integration will create 4 binary sensors for your selected region in Ukraine: | |
| - Air | |
| - Artillery | |
| - Urban Fights | |
| - Unknown |
Contributor
Author
There was a problem hiding this comment.
to offer alerts
Actually, the official term is "air-raid siren" or "civil defense siren" (https://en.wikipedia.org/wiki/Civil_defense_siren). "alerts" is too generic. I've merged your suggestion, but left the term. Is it ok?
| - Air | ||
| - Artillery | ||
| - Urban Fights | ||
| - Unknown |
Member
There was a problem hiding this comment.
Is it explained on the official site what the unknown alarm represents?
Contributor
Author
There was a problem hiding this comment.
No. I will ask support. I think it means "something is flying but we don't know what".
klaasnicolaas
added
parent-merged
thecode
reviewed
May 8, 2022
Co-authored-by: Shay Levy <levyshay1@gmail.com>
balloob
approved these changes
May 8, 2022
probot-home-assistant
Bot
removed
in-progress
Member
|
Cherry-picked into |
balloob
pushed a commit
that referenced
this pull request
May 8, 2022
Co-authored-by: Shay Levy <levyshay1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
As you know, more than 2 months ago Russian troops started invasion of Ukraine. They bombing our cities with rockets and artillery. I'm introducing a new component that exposes air-raid sirens in Ukraine into HA. Uses Ukraine Alarm API.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.