Add Ukraine Alarm integration#71501
Conversation
bdraco
left a comment
There was a problem hiding this comment.
Config flows require 100% test coverage before merging. Please add tests for the config flow.
Thanks 👍
|
Also, looks like I've disabled tests for my config_flow. Can I do it in a separate PR, so this component can be delivered sooner? |
Run our scaffold script to get some test template code for the config flow. |
We can't waive the requirement for tests: https://github.com/home-assistant/architecture/blob/master/adr/0010-integration-configuration.md#consequences
|
Co-authored-by: J. Nick Koston <nick@koston.org>
|
The code is set up with an optional selector when having to select into district/community. If no selection is made, pick the chosen state/district instead of it's children. The frontend currently does not currently support an optional select: see Home Assistant Design select card. Let me push a fix. |
|
@PaulAnnekov can you verify my latest changes still work? The tests pass but I wasn't able to test with an actual API key. |
|
@PaulAnnekov can you also add an updated screenshot to this PR without the text "hidden"? |
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Yep, it's working 🎊 .
Done. |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
|
Test failure is not related. I restarted the CI on that test group |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Co-authored-by: Martin Hjelmare <marhje52@gmail.com> Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
|
Thank you guys for fast review and assistance. You're great 🥳 . |
Breaking change
Proposed change
As you know, more than 2 months ago Russian troops started invasion of Ukraine. They bombing our cities with rockets and artillery. I'm introducing a new component that exposes air-raid sirens in Ukraine into HA. Uses Ukraine Alarm API.
In a config flow you can choose a region to watch and will get 4 binary sensors:
To better understand what happens.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: