Skip to content

Added documentation for new integration Loqed#22439

Merged
frenck merged 5 commits into
home-assistant:nextfrom
cpolhout:patch-2
Jun 28, 2023
Merged

Added documentation for new integration Loqed#22439
frenck merged 5 commits into
home-assistant:nextfrom
cpolhout:patch-2

Conversation

@cpolhout
Copy link
Copy Markdown

@cpolhout cpolhout commented Apr 19, 2022

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • [x ] Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [ x] The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Apr 19, 2022
@klaasnicolaas
Copy link
Copy Markdown
Member

Since you want to add new integration documentation this PR should be in the next branch and don't forget to include a link to core's pull request as well.

@klaasnicolaas klaasnicolaas added the in-progress This PR/Issue is currently being worked on label Apr 19, 2022
@cpolhout cpolhout changed the base branch from current to next April 20, 2022 07:42
@cpolhout cpolhout requested a review from teharris1 as a code owner April 20, 2022 07:42
@probot-home-assistant probot-home-assistant Bot added needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch and removed current This PR goes into the current branch labels Apr 20, 2022
@probot-home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.
(message by DocsTargetBranch)

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Apr 20, 2022
@cpolhout
Copy link
Copy Markdown
Author

Since you want to add new integration documentation this PR should be in the next branch and don't forget to include a link to core's pull request as well.

Thanks. I updated the PR

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unrelated commits in this documentation PR. Please git rebase your PR to clean it up.

Thanks! 👍

@mikewoudenberg
Copy link
Copy Markdown
Contributor

Rebased and cleaned up

@frenck frenck removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Jul 18, 2022
Comment thread source/_integrations/loqed.markdown Outdated
Comment thread source/_integrations/loqed.markdown Outdated
Comment thread source/_integrations/loqed.markdown Outdated
Comment thread source/_integrations/loqed.markdown Outdated
Comment thread source/_integrations/loqed.markdown Outdated
Comment thread source/_integrations/loqed.markdown Outdated
Comment thread source/_integrations/loqed.markdown Outdated
Comment thread source/_integrations/loqed.markdown Outdated
Comment thread source/_integrations/loqed.markdown Outdated
marcelveldt
marcelveldt previously approved these changes Jun 19, 2023
Comment thread source/_integrations/loqed.markdown Outdated
Comment thread source/_integrations/loqed.markdown Outdated
Comment thread source/_integrations/loqed.markdown Outdated
Comment thread source/_integrations/loqed.markdown Outdated
@frenck frenck added the parent-merged The parent PR has been merged already label Jun 28, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cpolhout 👍

../Frenck

@frenck frenck merged commit e9a1b5a into home-assistant:next Jun 28, 2023
@home-assistant home-assistant Bot removed parent-merged The parent PR has been merged already in-progress This PR/Issue is currently being worked on labels Jun 28, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants