Skip to content

Loqed integration#73126

Closed
cpolhout wants to merge 7 commits into
home-assistant:devfrom
mikewoudenberg:loqed-integration
Closed

Loqed integration#73126
cpolhout wants to merge 7 commits into
home-assistant:devfrom
mikewoudenberg:loqed-integration

Conversation

@cpolhout
Copy link
Copy Markdown

@cpolhout cpolhout commented Jun 6, 2022

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • [] New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @mikewoudenberg,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@cpolhout
Copy link
Copy Markdown
Author

cpolhout commented Jun 6, 2022

@frenck This is a new PR for the loqed-integration. Based on this PR: #70080
Thanks for reviewing the previous one. To answer your questions from the previous comments:

  • Missing tests. We require configuration flows to have 100% test coverage.
  • --> There are tests now!
  • What if the lock was not on my internal network? E.g., a remote lock at my parents?
    --> First priority, especially for security-reasons, was the local integration. Because thats what a lot of people prefer. Especially when it comes to front-door-locks. Together with the manufacturer I will discuss a remote integration.
  • Consider moving data handling using a DataUpdateCoordinator
    --> Done
  • How would it handle multiple locks?
    --> Multiple locks are currently separate integrations.

@frenck
Copy link
Copy Markdown
Member

frenck commented Jun 7, 2022

@cpolhout You already have PR #70080 open, why open a new PR?
Please update the existing PR so we can continue the review process there.

Thanks! 👍

../Frenck

@cpolhout cpolhout closed this Jun 7, 2022
@cpolhout
Copy link
Copy Markdown
Author

cpolhout commented Jun 7, 2022

Updated the previous PR

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants