Skip to content

Add Oracle connection string#17912

Merged
fabaff merged 1 commit into
nextfrom
bdraco-patch-4
May 23, 2021
Merged

Add Oracle connection string#17912
fabaff merged 1 commit into
nextfrom
bdraco-patch-4

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 20, 2021

Proposed change

Add Oracle connection string

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 20, 2021
@probot-home-assistant probot-home-assistant Bot added next This PR goes into the next branch has-parent This PR has a parent PR in another repo labels May 20, 2021
@bdraco bdraco removed has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 20, 2021
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label May 20, 2021
@klaasnicolaas klaasnicolaas added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label May 20, 2021
@bdraco bdraco added the parent-merged The parent PR has been merged already label May 23, 2021
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Personally I don't know many people who are running an Oracle DB server at home beside XE for playing around.

@fabaff fabaff merged commit 8740819 into next May 23, 2021
@delete-merged-branch delete-merged-branch Bot deleted the bdraco-patch-4 branch May 23, 2021 09:48
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label May 23, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants