Add support for Oracle DB in recorder#50090
Conversation
This change is not related to this PR and should be split into a separate PR. |
Alright, but without 0b37293, c0602fe will break MySQL recorder functionality, so this should go together. |
This reverts commit 0b37293.
bdraco
left a comment
There was a problem hiding this comment.
Should be good to go once https://github.com/home-assistant/core/pull/50090/files#r628692103 is addressed
|
@mciupak Should be good to go once the docs are updated to include Oracle connection strings |
bdraco
left a comment
There was a problem hiding this comment.
I took care of fixing the conflict and adding the docs
|
Finished retesting. All looks good |
Proposed change
This PR adds suport to for Oracle DB to the recorder component. There are 3 commits in this PR:
- 0b37293 updates sqlalchemy to 1.4.12 as this version fixes bug with Identity column for MySQL DBI have tested these changes with SQLite, MySQL, Postrges and of course with Oracle DB. Models were update with Identity column, but I am not sure if it should trigger schema version bump.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: