Skip to content

Add operating system to analytics#17612

Merged
frenck merged 2 commits into
nextfrom
add-os
Apr 28, 2021
Merged

Add operating system to analytics#17612
frenck merged 2 commits into
nextfrom
add-os

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Apr 27, 2021

Proposed change

  • Adds operating_system key to the payloads
  • Adds the version data contexts to use the current versions in examples (because we can)

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Apr 27, 2021
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Apr 27, 2021
@klaasnicolaas klaasnicolaas added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Apr 27, 2021
ha_domain: analytics
---

{% assign current_version = site.current_major_version | append: "." | append: site.current_minor_version | append: "." | append: site.current_patch_version %}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe nice detail :)

frenck
frenck previously approved these changes Apr 27, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

Comment thread source/_integrations/analytics.markdown Outdated
Comment thread source/_integrations/analytics.markdown Outdated
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@frenck frenck merged commit 5685636 into next Apr 28, 2021
@frenck frenck deleted the add-os branch April 28, 2021 17:34
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants