Skip to content

Add OS version and board type to analytics#49725

Merged
ludeeus merged 1 commit intodevfrom
analytics-os-board
Apr 28, 2021
Merged

Add OS version and board type to analytics#49725
ludeeus merged 1 commit intodevfrom
analytics-os-board

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Apr 26, 2021

Breaking change

Proposed change

Adds board type, and version if running our OS.

Note to self: Needs frontend + reciever updates

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (analytics) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Comment thread homeassistant/components/analytics/analytics.py
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ludeeus ludeeus marked this pull request as draft April 28, 2021 12:44
@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Apr 28, 2021

Marked as draft so it's not accidentally merged before home-assistant/analytics.home-assistant.io#121 is in production

@ludeeus ludeeus marked this pull request as ready for review April 28, 2021 17:10
@ludeeus ludeeus merged commit 296dc93 into dev Apr 28, 2021
@ludeeus ludeeus deleted the analytics-os-board branch April 28, 2021 17:13
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants