Skip to content

Clarify how to reboot Roomba to generate auto-discovery#17111

Merged
frenck merged 3 commits into
home-assistant:currentfrom
scyto:patch-2
Mar 25, 2021
Merged

Clarify how to reboot Roomba to generate auto-discovery#17111
frenck merged 3 commits into
home-assistant:currentfrom
scyto:patch-2

Conversation

@scyto
Copy link
Copy Markdown
Contributor

@scyto scyto commented Mar 23, 2021

Proposed change

Without this key piece of info most people will never experience DHCP auto discovery of their roomba.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Without this key piece of info most people will never experience DHCP auto discovery of their roomba.
@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 23, 2021
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Mar 23, 2021
capitalization of brand
@scyto
Copy link
Copy Markdown
Contributor Author

scyto commented Mar 23, 2021

Should I also add a note that we would like more name / mac address combinations - or just wait until folks log their roomba didn't auto discover via dhcp?

Comment thread source/_integrations/roomba.markdown Outdated
thanks for editing, i see more of your style to adopt - and i could have sworn i caught the spelling mistake.

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to merge into the current documentation at this point.

Thanks for the PRs @scyto 👍

@frenck frenck changed the title clarify how to reboot roomba to generate auto-discovery Clarify how to reboot Roomba to generate auto-discovery Mar 25, 2021
@frenck frenck merged commit d1630dd into home-assistant:current Mar 25, 2021
@probot-home-assistant probot-home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Mar 25, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants