Skip to content

Opentherm gw improvements#16878

Closed
Martidjen wants to merge 10 commits into
home-assistant:nextfrom
Martidjen:opentherm_gw_improvements
Closed

Opentherm gw improvements#16878
Martidjen wants to merge 10 commits into
home-assistant:nextfrom
Martidjen:opentherm_gw_improvements

Conversation

@Martidjen
Copy link
Copy Markdown
Contributor

@Martidjen Martidjen commented Mar 5, 2021

Proposed change

Making some improvements to the Opentherm Gateway integration:

  • Dividing temperature precision into precision for current temperature and precision for setpoint temperature
  • Added option for setpoint override mode, can be set to temporary or constant (some thermostats work better with constant mode)

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@homeassistant
Copy link
Copy Markdown

Hi @Martidjen, @nicolalandro,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 5, 2021
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Mar 5, 2021
@probot-home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.
(message by DocsTargetBranch)

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Mar 5, 2021
Splitting the parent PR into multiple ones, one per new feature. Splitting the documentation PR as well
@homeassistant
Copy link
Copy Markdown

Hi @nicolalandro,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@Martidjen
Copy link
Copy Markdown
Contributor Author

Looks like i've been branching from the current branch while trying to merge to next.. Let me start over

@Martidjen Martidjen closed this Mar 7, 2021
@probot-home-assistant probot-home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Mar 7, 2021
@Martidjen Martidjen deleted the opentherm_gw_improvements branch March 7, 2021 20:55
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants