Add Opentherm Gateway current and setpoint precision#47484
Merged
MartinHjelmare merged 20 commits intoMar 18, 2021
Conversation
Devided precision into read and set precision. Added option for setpoint override mode, can be set to temporary or constant (some thermostats work better with constant mode)
Fixing some issues found while testing and adding translations for new options
Fixing some issues after running local tests
8 tasks
Setting rights en sorting order to satisfy the checks in the pull request
Contributor
|
Translations should be handled separately, see here. |
Reverting changes to translations after comment on PR
Contributor
Author
|
Reverted my changes to the translations, thank you for replying |
Found some more changes to be corrected
MartinHjelmare
requested changes
Mar 6, 2021
Member
|
I recommend splitting this PR into two PRs, one per bullet in the description. |
mvn23
suggested changes
Mar 6, 2021
Splitting up the pull request. Setpoint override mode will be added in a separate pull request as a boolean
Forgot to remove these includes
Apparently the includes were supposed to be sorted on one line
Changes to the schema for yaml config are not allowed to be changed any more
The CONF_PRECISION constant is needed again after reverting the schema for yaml config options
8 tasks
Fixing some review comments, still getting a warning: RuntimeWarning: coroutine 'ConfigEntries.async_setup' was never awaited
As suggested by MartinHjelmare, thank you for your input Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
New settings for precision will both be set to the value of the old precision setting when coming from the previous version of this integration
mvn23
suggested changes
Mar 11, 2021
Added test for the options migration when updating from previous version
Member
|
@mvn23 ok with you? |
mvn23
approved these changes
Mar 18, 2021
Contributor
mvn23
left a comment
mvn23
left a comment
There was a problem hiding this comment.
Looks good to me 👍
Thanks @Martidjen for the PR and @MartinHjelmare for the review!
MartinHjelmare
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Dividing temperature precision into precision for current temperature and precision for setpoint temperature
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: