Skip to content

Add theme support to media control card#16282

Merged
frenck merged 3 commits intonextfrom
spacegaier-patch-9
Jan 25, 2021
Merged

Add theme support to media control card#16282
frenck merged 3 commits intonextfrom
spacegaier-patch-9

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Proposed change

Technically themes were already supported, but the card editor did not show it plus the card preview did not take it into account (no dynamic updating).

Note: Many other tweaks (e.g. spelling of other conf properties) to this page are part of this PR against current: #16281

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Jan 23, 2021
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Jan 23, 2021
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jan 23, 2021
Comment thread source/_lovelace/media-control.markdown Outdated
Comment thread source/_lovelace/media-control.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jan 23, 2021
Co-authored-by: Franck Nijhof <git@frenck.dev>
@spacegaier spacegaier requested a review from frenck January 23, 2021 12:27
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Jan 23, 2021
frenck
frenck previously approved these changes Jan 23, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 23, 2021
@frenck frenck merged commit 561294e into next Jan 25, 2021
@probot-home-assistant probot-home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Jan 25, 2021
@frenck frenck deleted the spacegaier-patch-9 branch January 25, 2021 19:10
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants