Skip to content

Allow themeing of media control card#8209

Merged
bramkragten merged 3 commits intohome-assistant:devfrom
spacegaier:media-card-theme
Jan 25, 2021
Merged

Allow themeing of media control card#8209
bramkragten merged 3 commits intohome-assistant:devfrom
spacegaier:media-card-theme

Conversation

@spacegaier
Copy link
Copy Markdown
Member

@spacegaier spacegaier commented Jan 22, 2021

Breaking change

Proposed change

  1. Allow themeing for media control card. Was already technically possible, but had no editor support plus did not work for previewing (too restrictive checks in updated()).
  2. Explicitly state in the card config interfaces where themes work (previously some relied on the generic [key: string]: any; in LovelaceCardConfig.
  3. Moved theme picker for picture card and picture entity card out of the side-by-side since there were already two other fields in the row for the actions and those need more space to e.g. provide a URL or navigation target. Was quite crowded.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@spacegaier spacegaier closed this Jan 25, 2021
@spacegaier spacegaier reopened this Jan 25, 2021
@bramkragten bramkragten merged commit a8b27e2 into home-assistant:dev Jan 25, 2021
@spacegaier spacegaier deleted the media-card-theme branch January 25, 2021 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants