Skip to content

Improve and update FAQ entry for unique ID#16260

Merged
frenck merged 10 commits into
nextfrom
spacegaier-patch-5
Jan 27, 2021
Merged

Improve and update FAQ entry for unique ID#16260
frenck merged 10 commits into
nextfrom
spacegaier-patch-5

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Proposed change

Added screenshot + more context info and links.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Jan 21, 2021
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Jan 21, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this should be moved into a more-info page and linked from the UI in the dialog that shows this message.

Comment thread source/_faq/unique_id.markdown Outdated
Comment thread source/_faq/unique_id.markdown Outdated
Comment thread source/_faq/unique_id.markdown Outdated
Comment thread source/_faq/unique_id.markdown Outdated
Comment thread source/_faq/unique_id.markdown Outdated
Comment thread source/_faq/unique_id.markdown Outdated
Comment thread source/_faq/unique_id.markdown Outdated
Comment thread source/_faq/unique_id.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jan 24, 2021
@spacegaier
Copy link
Copy Markdown
Member Author

Ideally, this should be moved into a more-info page and linked from the UI in the dialog that shows this message.

The UI dialog is pointing to exactly this FAQ page currently. That is why I updated it, since many people end up there.

What do you mean by "more-info page"?

spacegaier and others added 2 commits January 24, 2021 01:51
Co-authored-by: Franck Nijhof <git@frenck.dev>
@spacegaier spacegaier requested a review from frenck January 24, 2021 01:00
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @spacegaier 👍

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 27, 2021
@frenck frenck merged commit e2f470c into next Jan 27, 2021
@frenck frenck deleted the spacegaier-patch-5 branch January 27, 2021 11:35
@probot-home-assistant probot-home-assistant Bot removed in-progress This PR/Issue is currently being worked on awaits-parent Awaits the merge of an parent PR labels Jan 27, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants