Skip to content

Entity registry: Translate advanced section + direct link to entity customization#8181

Merged
bramkragten merged 3 commits intohome-assistant:devfrom
spacegaier:entity-advanced-trans-cust-link
Jan 27, 2021
Merged

Entity registry: Translate advanced section + direct link to entity customization#8181
bramkragten merged 3 commits intohome-assistant:devfrom
spacegaier:entity-advanced-trans-cust-link

Conversation

@spacegaier
Copy link
Copy Markdown
Member

@spacegaier spacegaier commented Jan 17, 2021

Depends upon PR #8180.

Breaking change

Proposed change

  1. Add direct link to entity customizations for entities that do not have a unique ID
  2. Translate advanced section of entity registry dialog
  3. Add "outlined" styling to advanced expansion panel
  4. Tweaked expansion panel to have a bit clearer visual structure

No unique ID:
image

Device entity:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier spacegaier changed the title Entity registry: Translate advanced section + link to customize Entity registry: Translate advanced section + direct link to entity customization Jan 17, 2021
@bramkragten
Copy link
Copy Markdown
Member

We should not promote entity customization in any way, it is very hacky...

@spacegaier spacegaier added the has-parent This PR has a parent PR that needs to be merged first label Jan 21, 2021
@spacegaier
Copy link
Copy Markdown
Member Author

As discussed with Bram I now safe guarded the link to the customization to only be visible for advanced users.
@bramkragten The already existing "Advanced settings" section to override a device entity's location is visible for all users. Correct and by design or should also be safe guarded?

@bramkragten bramkragten merged commit 8d06086 into home-assistant:dev Jan 27, 2021
@bramkragten bramkragten mentioned this pull request Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2021
@spacegaier spacegaier deleted the entity-advanced-trans-cust-link branch May 26, 2021 06:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR that needs to be merged first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants