-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Update instructions to install SenseHat in HassOs #15503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fc208f6
Update sensehat.markdown
denics f7bf8b5
Update sensehat.markdown
denics a718806
Update sensehat.markdown
denics e3c2dbe
Update sensehat.markdown
denics de43c66
Update sensehat.markdown
denics 86540aa
Update sensehat.markdown
denics aa7c251
Update sensehat.markdown
denics 7fc3acc
Update sensehat.markdown
denics 7676db2
Update sensehat.markdown
denics File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom deps is not recommend, we should not document that and/or writing instructions to use that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can add a warning if you think it is better, but this is the only way to make the integration works. Otherwise, we can remove the integration as it cannot be installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A warning makes no sense.
If it doesn't work without these workarounds, I suggest filing an issue and get the problem fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am filing an issue in "home-assistant/operating-system" to include support for RTIMUlib. Can we leave it as "workaround" ? or we will have change this text to something like:
You will not be able to use your SenseHat until issue 953 will not be solved.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't document issues.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frenck
The larger issue with the documentation is listing SenseHat as a supported device when it's not.
No need to be curt with @denics for trying to address the problem. Three tickets have already been filed and closed as stale. He's proposing two reasonable solutions to make this a better experience for your users.
If you honestly don't want to make it work, that's fine -- in that case, please remove SenseHat from your documentation so others don't waste time like I (and @denics) did.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry to hear about your issues. However, this is how it is. Feel free to contribute a fix @AgalmicVentures.
I'm fine with removing integrations if that is a better solution, especially if they are not maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @frenck , the issue here is not with the SenseHat integration, I even made a PR to make the integration more universal and I am ready to add a workflow to it. The problem is that HassOS does not provide a required library. In my "solution" I am suggesting a workaround if HassOS is not integrating the required library. I opened a ticket on HassOS to point that out and you moved it to core (I do not understand why).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because integration defines the installation requirements, not the OS.
If it can be installed by the custom deps add-on, it can be handled by defining dependencies in the integration. Both do the same: Installing Python packages.
Thus this is an integration issue (core), not the OS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gee, I sure wish I'd found this thread six hours ago. I wasted a ridiculous amount of time, thinking "Surely if it's in the documentation, the SenseHAT must work?". I appreciate that this is all done by volunteers, but like others have said, it would be ideal if we could just figure out how to get it working again, but if not REMOVE THE DAMN THING FROM THE DOCUMENTATION or list it as deprecated, something to save people like me from wasting their time.