Skip to content

Update instructions to install SenseHat in HassOs#15503

Closed
denics wants to merge 9 commits into
home-assistant:currentfrom
denics:patch-3
Closed

Update instructions to install SenseHat in HassOs#15503
denics wants to merge 9 commits into
home-assistant:currentfrom
denics:patch-3

Conversation

@denics
Copy link
Copy Markdown
Contributor

@denics denics commented Oct 31, 2020 •
edited
Loading

Added instruction for using SenseHat with HassOs

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@denics
Update sensehat.markdown
fc208f6 
Added instruction for using SenseHat with HassOs
@probot-home-assistant probot-home-assistant Bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 31, 2020
denics added 2 commits October 31, 2020 14:48
@denics
Update sensehat.markdown
f7bf8b5 
solved some issues with standard text
@denics
Update sensehat.markdown
a718806 
added language flag
This was referenced Oct 31, 2020
Closed
Closed
frenck
frenck requested changes Oct 31, 2020
View reviewed changes
Comment thread source/_integrations/sensehat.markdown Outdated
Comment thread source/_integrations/sensehat.markdown Outdated
Comment thread source/_integrations/sensehat.markdown Outdated
Comment thread source/_integrations/sensehat.markdown
- Install "Custom deps deployment" add-on. To do so
- add ``https://github.com/home-assistant/hassio-addons-development`` to your add-ons repositories
- select *Custom deps deployment* and enable it
- Configure "Custom deps deployment" add-on
Copy link
Copy Markdown
Member

@frenck frenck Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom deps is not recommend, we should not document that and/or writing instructions to use that.

Copy link
Copy Markdown
Contributor Author

@denics denics Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add a warning if you think it is better, but this is the only way to make the integration works. Otherwise, we can remove the integration as it cannot be installed.

Copy link
Copy Markdown
Member

@frenck frenck Nov 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A warning makes no sense.

If it doesn't work without these workarounds, I suggest filing an issue and get the problem fixed.

Copy link
Copy Markdown
Contributor Author

@denics denics Nov 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am filing an issue in "home-assistant/operating-system" to include support for RTIMUlib. Can we leave it as "workaround" ? or we will have change this text to something like:

You will not be able to use your SenseHat until issue 953 will not be solved.

What do you think?

Copy link
Copy Markdown
Member

@frenck frenck Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't document issues.

Copy link
Copy Markdown

@AgalmicVentures AgalmicVentures Nov 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck

Custom deps is not recommend, we should not document that and/or writing instructions to use that.
we don't document issues.

The larger issue with the documentation is listing SenseHat as a supported device when it's not.

No need to be curt with @denics for trying to address the problem. Three tickets have already been filed and closed as stale. He's proposing two reasonable solutions to make this a better experience for your users.

If you honestly don't want to make it work, that's fine -- in that case, please remove SenseHat from your documentation so others don't waste time like I (and @denics) did.

Copy link
Copy Markdown
Member

@frenck frenck Nov 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to hear about your issues. However, this is how it is. Feel free to contribute a fix @AgalmicVentures.

I'm fine with removing integrations if that is a better solution, especially if they are not maintained.

Copy link
Copy Markdown
Contributor Author

@denics denics Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @frenck , the issue here is not with the SenseHat integration, I even made a PR to make the integration more universal and I am ready to add a workflow to it. The problem is that HassOS does not provide a required library. In my "solution" I am suggesting a workaround if HassOS is not integrating the required library. I opened a ticket on HassOS to point that out and you moved it to core (I do not understand why).

Copy link
Copy Markdown
Member

@frenck frenck Nov 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because integration defines the installation requirements, not the OS.

If it can be installed by the custom deps add-on, it can be handled by defining dependencies in the integration. Both do the same: Installing Python packages.

Thus this is an integration issue (core), not the OS.

Copy link
Copy Markdown

@QuantumStar QuantumStar Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gee, I sure wish I'd found this thread six hours ago. I wasted a ridiculous amount of time, thinking "Surely if it's in the documentation, the SenseHAT must work?". I appreciate that this is all done by volunteers, but like others have said, it would be ideal if we could just figure out how to get it working again, but if not REMOVE THE DAMN THING FROM THE DOCUMENTATION or list it as deprecated, something to save people like me from wasting their time.

Comment thread source/_integrations/sensehat.markdown Outdated
Comment thread source/_integrations/sensehat.markdown
Comment thread source/_integrations/sensehat.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Oct 31, 2020
denics added 6 commits October 31, 2020 22:09
@denics
Update sensehat.markdown
e3c2dbe 
resolve two comments:



- Headers should be surrounded by empty new lines.
- "Installation" sounds confusing right here?
@denics
Update sensehat.markdown
de43c66 
corrected a comment
@denics
Update sensehat.markdown
86540aa 
resolve comment
@denics
Update sensehat.markdown
aa7c251 
fixed comment
@denics
Update sensehat.markdown
7fc3acc 
resolved comment
@denics
Update sensehat.markdown
7676db2 
sovled comment
@btwebz
Copy link
Copy Markdown

btwebz commented Nov 11, 2020

Hi all,
I'd really like to get my sensehat working too!
Would be great if someone could post some instructions on how to achieve this!
Thanks heaps

@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 11, 2020

@btwebz That is what this PR and discussion is about.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 10, 2021

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions Bot added the stale The PR had no activity for quite some time, and is marked as Stale label Jan 10, 2021
@phiwa99 phiwa99 mentioned this pull request Jan 11, 2021
Closed
@github-actions github-actions Bot closed this Jan 17, 2021
@probot-home-assistant probot-home-assistant Bot added Invalid and removed in-progress This PR/Issue is currently being worked on Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Jan 17, 2021
@svanlee
Copy link
Copy Markdown

svanlee commented Apr 23, 2021

New user: need instructions on how to install on hass.io please

@QuantumStar
Copy link
Copy Markdown

QuantumStar commented Sep 21, 2021

Guess nobody ever bothered to fix this, or update the documentation. What a huge waste of time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck requested changes

+2 more reviewers

@AgalmicVentures AgalmicVentures AgalmicVentures left review comments

@QuantumStar QuantumStar QuantumStar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@denics denics

Labels

current This PR goes into the current branch hacktoberfest-accepted Invalid stale The PR had no activity for quite some time, and is marked as Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@denics @btwebz @frenck @svanlee @QuantumStar @AgalmicVentures