Skip to content

Changed Documentation for better comprehensibility#15426

Merged
frenck merged 4 commits into
home-assistant:nextfrom
AlexSchmitz222:patch-1
Nov 8, 2020
Merged

Changed Documentation for better comprehensibility#15426
frenck merged 4 commits into
home-assistant:nextfrom
AlexSchmitz222:patch-1

Conversation

@AlexSchmitz222
Copy link
Copy Markdown
Contributor

@AlexSchmitz222 AlexSchmitz222 commented Oct 26, 2020

Proposed change

Updated documentation to better fit with the FRITZ!DECT product line

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 26, 2020
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Oct 26, 2020
@probot-home-assistant probot-home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Oct 26, 2020
@probot-home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.
(message by DocsTargetBranch)

@AlexSchmitz222
Copy link
Copy Markdown
Contributor Author

Hope I filled the PR correctly this time

@mib1185
Copy link
Copy Markdown
Member

mib1185 commented Oct 28, 2020

Hi @AlexSchmitz222 ,
you have to request the pull against the next branch, not the current.
To achieve this change:

  • click on EDIT next to the title (on the right side)
  • now you see an drop-down "base: current" which has to be changed to "base: next"
  • afterwards click on SAVE

regards,
Michael

Copy link
Copy Markdown
Member

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some small comments from my side 😃

Comment thread source/_integrations/fritzbox.markdown Outdated
Comment thread source/_integrations/fritzbox.markdown Outdated
@AlexSchmitz222 AlexSchmitz222 changed the base branch from current to next October 29, 2020 05:02
@AlexSchmitz222 AlexSchmitz222 removed their assignment Oct 29, 2020
@frenck frenck added hacktoberfest-accepted parent-merged The parent PR has been merged already next This PR goes into the next branch and removed current This PR goes into the current branch labels Oct 31, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AlexSchmitz222 👍

@frenck frenck merged commit 1950336 into home-assistant:next Nov 8, 2020
@probot-home-assistant probot-home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Nov 8, 2020
@AlexSchmitz222 AlexSchmitz222 deleted the patch-1 branch November 11, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! hacktoberfest-accepted has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants