Skip to content

Change fritzbox title for better product family distinction#42432

Merged
frenck merged 2 commits intohome-assistant:devfrom
AlexSchmitz222:patch-2
Nov 7, 2020
Merged

Change fritzbox title for better product family distinction#42432
frenck merged 2 commits intohome-assistant:devfrom
AlexSchmitz222:patch-2

Conversation

@AlexSchmitz222
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Change of Integration Name to better distinguish between the Device Tracker and the Smarthome Integrations

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added Hacktoberfest bugfix integration: fritzbox small-pr PRs with less than 30 lines. dependency-bump Pull requests that update a dependency file labels Oct 26, 2020
@MartinHjelmare MartinHjelmare changed the title Changed title for better product family distinction Change fritzbox title for better product family distinction Oct 26, 2020
@mib1185
Copy link
Copy Markdown
Member

mib1185 commented Oct 26, 2020

Hi @AlexSchmitz222 ,
I would suggest "AVM FRITZ!SmartHome" because the intergration controls FRITZ!DECT devices via FRITZ!Box, which together form the FRITZ!SmartHome.
regards,
Michael

@AlexSchmitz222
Copy link
Copy Markdown
Contributor Author

Seems like a good Idea. I myself considered "AVM FRITZ!DECT Smarthome" for some time but didn't went with it.

@AlexSchmitz222
Copy link
Copy Markdown
Contributor Author

Changed the documentation accordingly

@AlexSchmitz222
Copy link
Copy Markdown
Contributor Author

Hi @AlexSchmitz222 ,
I would suggest "AVM FRITZ!SmartHome" because the intergration controls FRITZ!DECT devices via FRITZ!Box, which together form the FRITZ!SmartHome.
regards,
Michael

Thanks for that Idea.

@mib1185
Copy link
Copy Markdown
Member

mib1185 commented Nov 5, 2020

Hi @MartinHjelmare ,
the failed test was related to #42614, but not to this PR.
Is it possible to restart the tests, so that they will be passed successful?
regards,
Michael

@MartinHjelmare
Copy link
Copy Markdown
Member

I've restarted the tests.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AlexSchmitz222 👍

@frenck frenck merged commit d77d7b2 into home-assistant:dev Nov 7, 2020
Thomas55555 pushed a commit to Thomas55555/core that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants