Skip to content

Add update available binary sensor and verify ssl for connection setup to synology_dsm#15413

Merged
Quentame merged 3 commits intohome-assistant:nextfrom
mib1185:next
Nov 3, 2020
Merged

Add update available binary sensor and verify ssl for connection setup to synology_dsm#15413
Quentame merged 3 commits intohome-assistant:nextfrom
mib1185:next

Conversation

@mib1185
Copy link
Copy Markdown
Member

@mib1185 mib1185 commented Oct 25, 2020

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 25, 2020
@frenck frenck changed the title doc update for home-assistant/core#42378 Add update available binary sensor to synology_dsm Oct 26, 2020
frenck
frenck previously approved these changes Oct 26, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Oct 26, 2020
@mib1185 mib1185 changed the title Add update available binary sensor to synology_dsm Add update available binary sensor and verfiy ssl for connection setup to synology_dsm Oct 26, 2020
@mib1185 mib1185 requested a review from frenck October 26, 2020 18:59
@frenck frenck added parent-merged The parent PR has been merged already hacktoberfest-accepted and removed awaits-parent Awaits the merge of an parent PR labels Oct 29, 2020
@Quentame Quentame changed the title Add update available binary sensor and verfiy ssl for connection setup to synology_dsm Add update available binary sensor and verify ssl for connection setup to synology_dsm Oct 31, 2020
Quentame
Quentame previously approved these changes Oct 31, 2020
@Quentame Quentame added awaits-parent Awaits the merge of an parent PR and removed parent-merged The parent PR has been merged already labels Oct 31, 2020
@mib1185
Copy link
Copy Markdown
Member Author

mib1185 commented Nov 1, 2020

sorry, accidental committed to the same branch on my fork, but already reverted it.

Quentame
Quentame previously approved these changes Nov 2, 2020
@Quentame Quentame added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Nov 2, 2020
Copy link
Copy Markdown
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add yourself as ha_codeowners (top of the file)

Copy link
Copy Markdown
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add yourself as ha_codeowners (top of the file)

@Quentame Quentame merged commit c657c3f into home-assistant:next Nov 3, 2020
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Nov 3, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 4, 2020

@Quentame Not a problem, but the code-owner data is synced from the codebase. There is no need to correct those 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! hacktoberfest-accepted has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants