Add update available binary sensor to synology_dsm#42378
Merged
Quentame merged 5 commits intohome-assistant:devfrom Oct 28, 2020
Merged
Add update available binary sensor to synology_dsm#42378Quentame merged 5 commits intohome-assistant:devfrom
Quentame merged 5 commits intohome-assistant:devfrom
Conversation
Contributor
mib1185
added a commit
to mib1185/home-assistant.io
that referenced
this pull request
Oct 25, 2020
mib1185
added a commit
to mib1185/home-assistant.io
that referenced
this pull request
Oct 25, 2020
8 tasks
mib1185
added a commit
to mib1185/home-assistant.io
that referenced
this pull request
Oct 25, 2020
This reverts commit 5b99abc.
Quentame
requested changes
Oct 26, 2020
Member
Quentame
left a comment
There was a problem hiding this comment.
One comment, otherwise, good for me 😉
oncleben31
approved these changes
Oct 27, 2020
Quentame
requested changes
Oct 27, 2020
Member
Quentame
left a comment
There was a problem hiding this comment.
Why have you added CONF_VERIFY_SSL in this PR ?
I was about to merge a "update available sensor" PR, and now it is getting bigger.
PR should be unitary (unless changes are small, < 50 lines).
And in any case, you should not add features into a PR that already beeing reviewed, that makes the reviewing work harder.
(Sorry I also should merge yesterday)
Create a new branch with those changes (can be called synology_dsm/add_verify_ssl).
Checkout to this branch, reset until 3d05b25 (correct spacing) and force push.
Open a new PR with the verify_ssl addition.
Thanks
PS: that will also help you to reach your Hacktoberfest PR goal 😉
Member
Author
21 tasks
mib1185
added a commit
to mib1185/home-assistant.io
that referenced
this pull request
Nov 2, 2020
mib1185
added a commit
to mib1185/home-assistant.io
that referenced
this pull request
Nov 2, 2020
mib1185
added a commit
to mib1185/home-assistant.io
that referenced
this pull request
Nov 2, 2020
This reverts commit 5b99abc.
mib1185
added a commit
to mib1185/home-assistant.io
that referenced
this pull request
Nov 2, 2020
Quentame
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Nov 3, 2020
…p to synology_dsm (#15413) * doc update for home-assistant/core#42378 * add verfiy ssl for connection setup * add @mib1185 as codeowner
Thomas55555
pushed a commit
to Thomas55555/core
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR make use of new features in python-synology lib v1.0.0 and extend the synology-dsm integration by a new binary-sensor 'update available'.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: