Skip to content

Add update available binary sensor to synology_dsm#42378

Merged
Quentame merged 5 commits intohome-assistant:devfrom
mib1185:synology-dsm
Oct 28, 2020
Merged

Add update available binary sensor to synology_dsm#42378
Quentame merged 5 commits intohome-assistant:devfrom
mib1185:synology-dsm

Conversation

@mib1185
Copy link
Copy Markdown
Member

@mib1185 mib1185 commented Oct 25, 2020

Proposed change

This PR make use of new features in python-synology lib v1.0.0 and extend the synology-dsm integration by a new binary-sensor 'update available'.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @mib1185,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as its been labeled with an integration (synology_dsm) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

mib1185 added a commit to mib1185/home-assistant.io that referenced this pull request Oct 25, 2020
mib1185 added a commit to mib1185/home-assistant.io that referenced this pull request Oct 25, 2020
mib1185 added a commit to mib1185/home-assistant.io that referenced this pull request Oct 25, 2020
Copy link
Copy Markdown
Contributor

@oncleben31 oncleben31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@springstan springstan changed the title 'update available' binary-sensor Add update available binary sensor to synology_dsm Oct 26, 2020
Copy link
Copy Markdown
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise, good for me 😉

Comment thread homeassistant/components/synology_dsm/binary_sensor.py
@mib1185 mib1185 requested a review from Quentame October 26, 2020 09:19
@mib1185 mib1185 changed the title Add update available binary sensor to synology_dsm Add update available binary sensor and verfiy ssl for connection setup to synology_dsm Oct 26, 2020
@mib1185 mib1185 marked this pull request as draft October 26, 2020 19:06
@mib1185 mib1185 marked this pull request as ready for review October 26, 2020 22:02
Copy link
Copy Markdown
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you added CONF_VERIFY_SSL in this PR ?

I was about to merge a "update available sensor" PR, and now it is getting bigger.

PR should be unitary (unless changes are small, < 50 lines).
And in any case, you should not add features into a PR that already beeing reviewed, that makes the reviewing work harder.
(Sorry I also should merge yesterday)


Create a new branch with those changes (can be called synology_dsm/add_verify_ssl).
Checkout to this branch, reset until 3d05b25 (correct spacing) and force push.
Open a new PR with the verify_ssl addition.

Thanks

PS: that will also help you to reach your Hacktoberfest PR goal 😉

@mib1185
Copy link
Copy Markdown
Member Author

mib1185 commented Oct 28, 2020

Hi @Quentame ,
I reverted changes for this PR back to 3d05b25 (correct spacing).
After the PR is reviewed and merged, I will open a new PR for adding the ssl verification.
Sorry for confusion about adding additional changes.

regards,
Michael

@mib1185 mib1185 requested a review from Quentame October 28, 2020 18:14
@Quentame Quentame changed the title Add update available binary sensor and verfiy ssl for connection setup to synology_dsm Add update available binary sensor to synology_dsm Oct 28, 2020
Copy link
Copy Markdown
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working.

@Quentame Quentame merged commit 36b1756 into home-assistant:dev Oct 28, 2020
mib1185 added a commit to mib1185/home-assistant.io that referenced this pull request Nov 2, 2020
mib1185 added a commit to mib1185/home-assistant.io that referenced this pull request Nov 2, 2020
mib1185 added a commit to mib1185/home-assistant.io that referenced this pull request Nov 2, 2020
mib1185 added a commit to mib1185/home-assistant.io that referenced this pull request Nov 2, 2020
Quentame pushed a commit to home-assistant/home-assistant.io that referenced this pull request Nov 3, 2020
…p to synology_dsm (#15413)

* doc update for home-assistant/core#42378

* add verfiy ssl for connection setup

* add @mib1185 as codeowner
@mib1185 mib1185 deleted the synology-dsm branch May 11, 2021 17:40
Thomas55555 pushed a commit to Thomas55555/core that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants