Quick Bar dialog documentation by donkawechico · Pull Request #15033 · home-assistant/home-assistant.io

donkawechico · 2020-10-07T19:57:13Z

Proposed change

Documentation for new "quick open dialog" currently in progress here: home-assistant/frontend#7230

Type of change

Spelling, grammar or other readability improvements (current branch).
Adjusted missing or incorrect information in the current documentation (current branch).
Added documentation for a new integration I'm adding to Home Assistant (next branch).
- I've opened up a PR to add logo's and icons in Brands repository.
Added documentation for a new feature I'm adding to Home Assistant (next branch).
Removed stale or deprecated documentation.

Additional information

Link to parent pull request in the codebase: Add "quick open" style dialog for selecting entities and running reload commands frontend#7230
Link to parent pull request in the Brands repository:
This PR fixes or closes issue:

Checklist

This PR uses the correct branch, based on one of the following:
- I made a change to the existing documentation and used the current branch.
- I made a change that is related to an upcoming version of Home Assistant and used the next branch.
The documentation follows the Home Assistant documentation standards.

donkawechico · 2020-10-07T20:03:43Z

~~Holy files changed! Must've based this off of current instead of next? Stand by...~~

Update: Resolved

SeanPM5

Looks good, just a few small review comments.

donkawechico · 2020-10-07T23:08:27Z

Looks good, just a few small review comments.

Good catches! Resolved

donkawechico · 2020-10-08T14:25:52Z

Parent pr merged

Co-authored-by: Sean Mooney <sean.mooney@gmail.com>

donkawechico · 2020-10-08T19:06:17Z

@SeanPM5 I took a look at the docs with fresh eyes and made a few small adjustments. Also had forgotten to add the page to the "Tools and Helpers" section of right nav.

Could you give it a quick re-review? Thanks

SeanPM5

The file extension should probably end in .markdown rather than .md for consistency sake with the rest of the docs repo.

I was a little iffy on all the mentions of “the application” because that could possibly confuse some readers into thinking of the mobile apps (which don’t support this feature yet). So I made a handful of suggestions to change those to just “frontend” instead.

Otherwise this looks good to me, approved. frenck or balloob should probably be the one to merge it though, not sure I'm allowed :P

P.S. - I dig the new Quick Bar name, and this is a seriously killer feature. Everyone’s going to absolutely love this, amazing contribution! 🎉

Co-authored-by: Sean Mooney <sean.mooney@gmail.com>

donkawechico · 2020-10-11T19:21:20Z

One thing to note is that this feature may still work its way into the mobile apps (long-press, small hover-button, or gestures). At which point we should remember to update the docs to switch "frontend" back to something more general like application.

donkawechico · 2020-10-11T19:28:41Z

P.S. - I dig the new Quick Bar name, and this is a seriously killer feature. Everyone’s going to absolutely love this, amazing contribution! 🎉

Thanks @SeanPM5! I'm super excited about it. I've already caught myself trying to use the hotkey in my production instance and then getting annoyed that it isn't there yet 😆

donkawechico · 2020-10-20T22:06:31Z

 This is similar to many modern developer-based applications like Sublime, VSCode, Chrome Developer Tools and GitHub file search do "quick file filter" searches.

-This can be really helpful when you have LOTS of entities with the same substring (e.g. "\*.living_room_\*"), but you only care about a particular _domain_. For example, rather than type out "media_player.living_" to narrow down media players in your living room, you can just type, say, "med.livroom" and get back the same set with less typing.
+This can be really helpful when you have LOTS of entities with the same substring (e.g., "\*.living_room_\*"), but you only care about a particular _domain_. For example, rather than type out "media_player.living_" to narrow down media players in your living room, you can just type, say, "med.livroom" and get back the same set with less typing.


Nice catches. TIL

donkawechico · 2020-10-20T22:07:48Z

We've pushed a lot of changes to quick bar in the last week. I should probably freshen this up before we release.

frenck · 2020-10-20T22:13:27Z

@donkawechico Well, now is the time, as the beta is being cut in a couple of hours.

frenck · 2020-10-20T22:15:40Z

Do you want me to hold this PR? Or do you want to create a new one?

donkawechico · 2020-10-20T22:55:05Z

Do you want me to hold this PR? Or do you want to create a new one?

Please go ahead merge if I don't push changes before the cut. The differences are not a big deal.

probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 7, 2020

donkawechico mentioned this pull request Oct 7, 2020

Add "quick open" style dialog for selecting entities and running reload commands home-assistant/frontend#7230

Merged

9 tasks

donkawechico force-pushed the quick_open_dialog_documentation branch 4 times, most recently from d192da3 to 1bebe9e Compare October 7, 2020 20:28

donkawechico marked this pull request as ready for review October 7, 2020 20:30

Add documentation for new 'quick open dialog'

bfa657d

donkawechico force-pushed the quick_open_dialog_documentation branch from 1bebe9e to bfa657d Compare October 7, 2020 20:32

SeanPM5 requested changes Oct 7, 2020

View reviewed changes

Comment thread source/_docs/tools/quick-open.md Outdated

Comment thread source/_docs/tools/quick-open.md Outdated

Comment thread source/_docs/tools/quick-open.md Outdated

Comment thread source/_docs/tools/quick-open.md Outdated

donkawechico force-pushed the quick_open_dialog_documentation branch from c31dcb2 to 31f5b13 Compare October 8, 2020 18:55

Swap Hotkey headers and expand abbreviations

b0679c0

Co-authored-by: Sean Mooney <sean.mooney@gmail.com>

donkawechico force-pushed the quick_open_dialog_documentation branch from 31f5b13 to b0679c0 Compare October 8, 2020 19:03

Change filename and add to 'Tools and Helpers'

5e27e4d

frenck added the parent-merged The parent PR has been merged already label Oct 9, 2020

donkawechico mentioned this pull request Oct 9, 2020

Rename 'quick open dialog' to 'quick bar' home-assistant/frontend#7286

Merged

9 tasks

Rename "Quick Open Dialog" to "Quick Bar"

37910f9

SeanPM5 previously approved these changes Oct 9, 2020

View reviewed changes

SeanPM5 changed the title ~~Quick open dialog documentation~~ Quick Bar dialog documentation Oct 9, 2020

Update source/_docs/tools/quick-bar.md

4b8253d

Co-authored-by: Sean Mooney <sean.mooney@gmail.com>

donkawechico dismissed SeanPM5’s stale review via 4b8253d October 11, 2020 19:01

donkawechico and others added 3 commits October 11, 2020 12:06

Update source/_docs/tools/quick-bar.md

5507ae9

Co-authored-by: Sean Mooney <sean.mooney@gmail.com>

Update source/_docs/tools/quick-bar.md

546a84b

Co-authored-by: Sean Mooney <sean.mooney@gmail.com>

Update source/_docs/tools/quick-bar.md

c47853c

Co-authored-by: Sean Mooney <sean.mooney@gmail.com>

Change file extension to .markdown for consistency

5fe8d5c

✏️ Tweaks

8a99ae1

donkawechico commented Oct 20, 2020

View reviewed changes

Comment thread source/_docs/tools/quick-bar.markdown Outdated

✏️ Tweaks

40bec9f

donkawechico commented Oct 20, 2020

View reviewed changes

frenck approved these changes Oct 20, 2020

View reviewed changes

frenck merged commit 0a9a8f2 into home-assistant:next Oct 20, 2020

probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Oct 20, 2020

Uh oh!

Conversation

donkawechico commented Oct 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

donkawechico commented Oct 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SeanPM5 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

donkawechico commented Oct 7, 2020

Uh oh!

donkawechico commented Oct 8, 2020

Uh oh!

donkawechico commented Oct 8, 2020

Uh oh!

SeanPM5 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

donkawechico commented Oct 11, 2020

Uh oh!

donkawechico commented Oct 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

donkawechico Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

donkawechico commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frenck commented Oct 20, 2020

Uh oh!

frenck commented Oct 20, 2020

Uh oh!

donkawechico commented Oct 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

donkawechico commented Oct 7, 2020 •

edited

Loading

donkawechico commented Oct 7, 2020 •

edited

Loading

donkawechico commented Oct 11, 2020 •

edited

Loading

donkawechico commented Oct 20, 2020 •

edited

Loading