Skip to content

Add plugwise port configuration#14488

Closed
CoMPaTech wants to merge 3 commits intohome-assistant:nextfrom
plugwise:plugwise-port
Closed

Add plugwise port configuration#14488
CoMPaTech wants to merge 3 commits intohome-assistant:nextfrom
plugwise:plugwise-port

Conversation

@CoMPaTech
Copy link
Copy Markdown
Member

@CoMPaTech CoMPaTech commented Sep 13, 2020

Proposed change

Adding line indicating port number can be used for advanced users having different port numbers

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: Add port to plugwise core#40017
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Sep 13, 2020
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Sep 13, 2020
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Sep 13, 2020
@probot-home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.
(message by DocsTargetBranch)

@CoMPaTech
Copy link
Copy Markdown
Member Author

Not sure why probot designates this as as current

@CoMPaTech CoMPaTech removed their assignment Sep 13, 2020
@ludeeus ludeeus closed this Sep 13, 2020
@ludeeus ludeeus reopened this Sep 13, 2020
@probot-home-assistant probot-home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Sep 13, 2020
@ludeeus
Copy link
Copy Markdown
Member

ludeeus commented Sep 13, 2020

When it was opened it was missing the link to the core PR

@CoMPaTech
Copy link
Copy Markdown
Member Author

When it was opened it was missing the link to the core PR

I'll open the core one first next time, apologies!

bouwew
bouwew previously approved these changes Sep 13, 2020
Copy link
Copy Markdown
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More clear after rewording, tnx!

@klaasnicolaas klaasnicolaas added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Sep 13, 2020
Comment thread source/_integrations/plugwise.markdown Outdated
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Sep 14, 2020
@CoMPaTech
Copy link
Copy Markdown
Member Author

Closing this as the approach changed, will merge the supported firmware versions with #14508

@CoMPaTech CoMPaTech closed this Sep 17, 2020
@probot-home-assistant probot-home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Sep 17, 2020
CoMPaTech added a commit to plugwise/home-assistant.io that referenced this pull request Sep 17, 2020
@bouwew bouwew deleted the plugwise-port branch November 7, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants