Skip to content

Add port to plugwise#40017

Merged
ludeeus merged 10 commits intohome-assistant:devfrom
plugwise:plugwise-port
Sep 19, 2020
Merged

Add port to plugwise#40017
ludeeus merged 10 commits intohome-assistant:devfrom
plugwise:plugwise-port

Conversation

@CoMPaTech
Copy link
Copy Markdown
Member

@CoMPaTech CoMPaTech commented Sep 13, 2020

Proposed change

Handle additional port number present to facilitate people with out-of-subnet local Smiles.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@CoMPaTech
Copy link
Copy Markdown
Member Author

Re-tested (succesfully) locally as per lint error on last commit

@springstan springstan changed the title Plugwise port Handle port in host for plugwise Sep 13, 2020
Copy link
Copy Markdown
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
This code has been tested by the original requester of this feature via the Plugwise-beta custom_component.

Comment thread homeassistant/components/plugwise/config_flow.py Outdated
Comment thread homeassistant/components/plugwise/config_flow.py Outdated
@CoMPaTech
Copy link
Copy Markdown
Member Author

Removed docs-PR

Comment thread homeassistant/components/plugwise/config_flow.py Outdated
@ludeeus ludeeus changed the title Handle port in host for plugwise Add port to plugwise Sep 19, 2020
Copy link
Copy Markdown
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ludeeus ludeeus merged commit 5832184 into home-assistant:dev Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants