Skip to content

Amendment comments for plugwise platform update#13650

Merged
frenck merged 3 commits into
home-assistant:nextfrom
plugwise:plugwise-async-platform-amendment2
Jun 2, 2020
Merged

Amendment comments for plugwise platform update#13650
frenck merged 3 commits into
home-assistant:nextfrom
plugwise:plugwise-async-platform-amendment2

Conversation

@CoMPaTech
Copy link
Copy Markdown
Member

@CoMPaTech CoMPaTech commented Jun 2, 2020

Proposed change

As commented by co-author in #13640 some small changes:

Sorry, I'm a little late :)

23: climate: a single Tom can also be a climate-entity. Please add Tom in the list.
140: typo nd --> and
29, 141: plug --> Plug

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Jun 2, 2020
@bouwew
Copy link
Copy Markdown
Contributor

bouwew commented Jun 2, 2020

Very good, thanks!

@CoMPaTech CoMPaTech marked this pull request as ready for review June 2, 2020 14:06
@CoMPaTech
Copy link
Copy Markdown
Member Author

Add changes due to #36378 (adding binary_sensor)

@CoMPaTech CoMPaTech marked this pull request as draft June 2, 2020 17:29
@CoMPaTech
Copy link
Copy Markdown
Member Author

Temp. set to draft as homeassistant.core#36383 is also running

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Jun 2, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Jun 2, 2020

@CoMPaTech ? That core PR you are referencing has been merged already, why is this draft?

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jun 2, 2020
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jun 2, 2020
@CoMPaTech
Copy link
Copy Markdown
Member Author

I'll reference the ones this one is against. It started out as changes to the amendment.

Copy link
Copy Markdown
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@CoMPaTech CoMPaTech marked this pull request as ready for review June 2, 2020 17:50
@CoMPaTech
Copy link
Copy Markdown
Member Author

@frenck sorry for the inconvenience, due to the great efforts of Nick and Martin we are all-in for beta. The #36383 is approved and most likely will be merged as soon as testing is done with it and this can go as well.

bouwew
bouwew approved these changes Jun 2, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Jun 2, 2020
@frenck frenck merged commit 08244c1 into home-assistant:next Jun 2, 2020
@probot-home-assistant probot-home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Jun 2, 2020
@bouwew bouwew deleted the plugwise-async-platform-amendment2 branch November 7, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants