Skip to content

Amendment for plugwise platform update#13640

Merged
frenck merged 1 commit into
home-assistant:nextfrom
plugwise:plugwise-async-platform-amendment
Jun 1, 2020
Merged

Amendment for plugwise platform update#13640
frenck merged 1 commit into
home-assistant:nextfrom
plugwise:plugwise-async-platform-amendment

Conversation

@CoMPaTech
Copy link
Copy Markdown
Member

Proposed change

As two of our PRs are still to be filed (i.e. binary_sensor and switch) the documentation should reflect this. I wrote it down as todo in one of the child PRs, but we pinged ok for merge and it slipped my mind while fetching tea :(

For those rightfully wondering: the statements in the documentation are still correct, Anna support continues (though breaking as per config_flow instead of yaml) and Adam and P1 users able to use this. The upcoming PRs handle 'plugs' (i.e. switches within a climate environment) and domestic how water and secondary heater binary_sensors.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: Update plugwise platform #12738
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jun 1, 2020
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Jun 1, 2020
@probot-home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.
(message by DocsTargetBranch)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CoMPaTech 👍

@frenck frenck removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jun 1, 2020
@frenck frenck merged commit 8b9b646 into home-assistant:next Jun 1, 2020
Copy link
Copy Markdown
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm a little late :)

23: climate: a single Tom can also be a climate-entity. Please add Tom in the list.
140: typo nd --> and
29, 141: plug --> Plug

CoMPaTech pushed a commit to plugwise/home-assistant.io that referenced this pull request Jun 2, 2020
@bouwew bouwew deleted the plugwise-async-platform-amendment branch November 7, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants