Skip to content

Songpal code improvement #13327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 3 commits into from
May 12, 2020
Merged

Songpal code improvement #13327

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
876dd35
Change songpal/set_sound_setting behavior
shenxn May 7, 2020
8ba97fb
Change entity_id to optional
shenxn May 7, 2020
64cd381
Add quality scale
shenxn May 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion source/_integrations/songpal.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ ha_category:
ha_iot_class: Local Push
ha_release: 0.65
ha_config_flow: true
ha_quality_scale: gold
ha_codeowners:
- '@rytilahti'
- '@shenxn'
Expand Down Expand Up @@ -58,6 +59,6 @@ For a list of available settings and their values use [`songpal sound`](https://

| Service data attribute | Optional | Description |
|------------------------|----------|--------------------------------------------------|
| `entity_id` | yes | Target entity, leave unset for all devices |
| `entity_id` | yes | Target entity. To target all songpal devices, use `all` |
| `name` | no | Configuration variable, e.g., `nightmode` |
| `value` | no | New configuration value, e.g., `on` |