Skip to content

Songpal code improvement#13327

Merged
frenck merged 3 commits into
home-assistant:nextfrom
shenxn:patch-4
May 12, 2020
Merged

Songpal code improvement#13327
frenck merged 3 commits into
home-assistant:nextfrom
shenxn:patch-4

Conversation

@shenxn
Copy link
Copy Markdown
Contributor

@shenxn shenxn commented May 7, 2020

Proposed change

  • The songpal/set_sound_setting now uses service registration helper to register so the entity_id need to be set as all instead of left unset to call the service on all songpal devices.
  • The integration now reaches gold quality scale.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels May 7, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @shenxn!

entity_id is optional for these service calls (one could target an area instead).

Comment thread source/_integrations/songpal.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label May 7, 2020
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label May 7, 2020
@shenxn shenxn requested a review from frenck May 7, 2020 13:14
frenck
frenck previously approved these changes May 7, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels May 7, 2020
@shenxn shenxn changed the title Change songpal/set_sound_setting entity_id behavior Songpal code improvement May 8, 2020
shenxn and others added 2 commits May 8, 2020 15:37
@frenck frenck added the parent-merged The parent PR has been merged already label May 12, 2020
@frenck frenck merged commit 3b80474 into home-assistant:next May 12, 2020
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels May 12, 2020
@shenxn shenxn deleted the patch-4 branch May 12, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants