Skip to content

Add documentation for Neptune Apex#13151

Closed
jpelzer wants to merge 4 commits into
home-assistant:nextfrom
jpelzer:readd-neptune-apex
Closed

Add documentation for Neptune Apex#13151
jpelzer wants to merge 4 commits into
home-assistant:nextfrom
jpelzer:readd-neptune-apex

Conversation

@jpelzer
Copy link
Copy Markdown
Contributor

@jpelzer jpelzer commented Apr 24, 2020

This reverts commit e723871.

Proposed change

Adds documentation for new integration Neptune Apex, the Neptune System Apex Aquacontroller, an aquarium automation system.

This documentation was prematurely merged and reverted prior to the integration being accepted into core (#13138), so this pull request is a revert of the reversion, and should only be merged when the parent pull has been accepted.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Apr 24, 2020
@frenck frenck changed the title Revert "Revert "Added documentation for Neptune Apex." (#13149)" Add documentation for Neptune Apex Apr 24, 2020
@klaasnicolaas klaasnicolaas added the new-integration This PR adds documentation for a new Home Assistant integration label May 1, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @jpelzer!

Reviewed your PR and left 2 small suggestions. Could you take a look? Thanks! 👍

Comment thread source/_integrations/neptune_apex.markdown Outdated
Comment thread source/_integrations/neptune_apex.markdown
@frenck frenck added the in-progress This PR/Issue is currently being worked on label May 1, 2020
@jpelzer jpelzer requested a review from frenck May 3, 2020 02:41
Comment thread source/_integrations/neptune_apex.markdown
@jpelzer jpelzer requested a review from klaasnicolaas May 3, 2020 13:54
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels May 8, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 18, 2020

Closing PR as the parent PR has been closed.

@frenck frenck closed this Jul 18, 2020
@probot-home-assistant probot-home-assistant Bot removed the awaits-parent Awaits the merge of an parent PR label Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants