Add integration support for Neptune Systems Apex Aquacontroller

[jpelzer]

Proposed change

Adds support for the Neptune Systems Apex Aquacontroller, an IP-connected aquarium controller. Has support for probes and outlet controls.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• Link to documentation pull request:
  Added documentation for Neptune Apex. home-assistant.io#13138

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[homeassistant]

Hi @jpelzer,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[jpelzer]

Not sure how to get cla-error label removed, as the issue with the committer email has been resolved but the bot hasn't removed the label. Does pinging @homeassistant make the bot recheck?

[Apocrathia]

Well I'll be damned. I had looked into this years ago using the same sort of XML scraping method that your pynepsys library is using, but never pursued it after having some issues with Neptune and abandoning their ecosystem. I'm sure a lot of people still use their products, though. Great work! 👍

[frenck]

@Apocrathia Totally OT... but I have to respond. Your GitHub Avatar just made my brain travel back in time. "Mmmm... I'm thirsty!" 😂 👍

[jpelzer]

Alright, so this one should be good to go, ready for reviewers to tear into.

Docs and images are in PR again:
home-assistant/home-assistant.io#13151
home-assistant/brands#1490

[stale]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[stale]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[davidpesce]

Why wasn't this merged?

[MartinHjelmare]

It went stale with a failed build. The author can request to have it reopened if ready to finish it.