Skip to content

Add ShowOnMap flag to show each/hide entity on map#12541

Merged
frenck merged 6 commits into
home-assistant:nextfrom
FlavorFx:Tankerkoenig
Apr 3, 2020
Merged

Add ShowOnMap flag to show each/hide entity on map#12541
frenck merged 6 commits into
home-assistant:nextfrom
FlavorFx:Tankerkoenig

Conversation

@FlavorFx
Copy link
Copy Markdown
Contributor

@FlavorFx FlavorFx commented Mar 29, 2020

Proposed change

In Tankerkoenig the display of the sensors on the map can be switched on or off.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Mar 29, 2020
guillempages
guillempages suggested changes Mar 29, 2020
View reviewed changes
Comment thread source/_integrations/tankerkoenig.markdown Outdated
Comment thread source/_integrations/tankerkoenig.markdown
FlavorFx and others added 2 commits March 29, 2020 23:43
@FlavorFx
Update tankerkoenig.markdown
c29473d
@FlavorFx @guillempages
Update source/_integrations/tankerkoenig.markdown
37cea2e 
Co-Authored-By: guillempages <guillempages@users.noreply.github.com>
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Mar 30, 2020
frenck
frenck requested changes Mar 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @FlavorFx!

I've left a couple of comments and suggestions, could you please take a look? thanks! 👍

Comment thread source/_integrations/tankerkoenig.markdown Outdated
Comment thread source/_integrations/tankerkoenig.markdown Outdated
Comment thread source/_integrations/tankerkoenig.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Mar 30, 2020
FlavorFx and others added 3 commits March 30, 2020 15:49
@FlavorFx @frenck
Update source/_integrations/tankerkoenig.markdown
942c0fe 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@FlavorFx @frenck
Update source/_integrations/tankerkoenig.markdown
cd51404 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@FlavorFx @frenck
Update source/_integrations/tankerkoenig.markdown
4d0442b 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
guillempages
guillempages approved these changes Mar 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@guillempages guillempages left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

frenck
frenck approved these changes Mar 31, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Mar 31, 2020
@frenck frenck added the parent-merged The parent PR has been merged already label Apr 3, 2020
@frenck frenck merged commit bd6dd1d into home-assistant:next Apr 3, 2020
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

+1 more reviewer

@guillempages guillempages guillempages approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FlavorFx @frenck @guillempages