Skip to content

Add unique id and show on map option in Tankerkoenig#33400

Merged
bdraco merged 12 commits intohome-assistant:devfrom
FlavorFx:tankerkoenig
Apr 3, 2020
Merged

Add unique id and show on map option in Tankerkoenig#33400
bdraco merged 12 commits intohome-assistant:devfrom
FlavorFx:tankerkoenig

Conversation

@FlavorFx
Copy link
Copy Markdown
Contributor

Proposed change

Tankerkoenig now enables friendly names. This Lovelace UI you can edit the entity name. Furthermore, the display of the sensors on the map can be switched on or off.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

tankerkoenig:
  show_on_map: false

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @FlavorFx,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @guillempages, mind taking a look at this pull request as its been labeled with a integration (tankerkoenig) you are listed as a codeowner for? Thanks!

Comment thread homeassistant/components/tankerkoenig/sensor.py
Comment thread homeassistant/components/tankerkoenig/sensor.py
vol.Optional(CONF_STATIONS, default=[]): vol.All(
cv.ensure_list, [cv.string]
),
vol.Optional(CONF_SHOW_ON_MAP, default=False

This comment was marked as resolved.

Comment thread homeassistant/components/tankerkoenig/sensor.py Outdated
Comment thread homeassistant/components/tankerkoenig/sensor.py Outdated
Comment thread homeassistant/components/tankerkoenig/sensor.py Outdated
Comment thread homeassistant/components/tankerkoenig/sensor.py Outdated
Comment thread homeassistant/components/tankerkoenig/__init__.py
@springstan springstan changed the title Add friendly name support and show on map option in Tankerkoenig Add unique id and show on map option in Tankerkoenig Mar 30, 2020
Copy link
Copy Markdown
Contributor

@guillempages guillempages left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 2, 2020

@FlavorFx
The CI issues should be fixed so it should run cleanly if you rebase

https://developers.home-assistant.io/docs/development_catching_up/

@FlavorFx
Copy link
Copy Markdown
Contributor Author

FlavorFx commented Apr 3, 2020

I forced push but still ci failure. What do I need to do?

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bdraco bdraco merged commit b7dd8cd into home-assistant:dev Apr 3, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants