Add unique id and show on map option in Tankerkoenig#33400
Merged
bdraco merged 12 commits intohome-assistant:devfrom Apr 3, 2020
FlavorFx:tankerkoenig
Merged
Add unique id and show on map option in Tankerkoenig#33400bdraco merged 12 commits intohome-assistant:devfrom FlavorFx:tankerkoenig
bdraco merged 12 commits intohome-assistant:devfrom
FlavorFx:tankerkoenig
Conversation
Contributor
|
Hey there @guillempages, mind taking a look at this pull request as its been labeled with a integration ( |
7 tasks
guillempages
suggested changes
Mar 29, 2020
| vol.Optional(CONF_STATIONS, default=[]): vol.All( | ||
| cv.ensure_list, [cv.string] | ||
| ), | ||
| vol.Optional(CONF_SHOW_ON_MAP, default=False |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
|
@FlavorFx https://developers.home-assistant.io/docs/development_catching_up/ |
Co-Authored-By: guillempages <guillempages@users.noreply.github.com>
Co-Authored-By: guillempages <guillempages@users.noreply.github.com>
Co-Authored-By: guillempages <guillempages@users.noreply.github.com>
Co-Authored-By: guillempages <guillempages@users.noreply.github.com>
Contributor
Author
|
I forced push but still ci failure. What do I need to do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Tankerkoenig now enables friendly names. This Lovelace UI you can edit the entity name. Furthermore, the display of the sensors on the map can be switched on or off.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: