add agent_dvr#12333
Merged
frenck merged 9 commits intohome-assistant:nextfrom May 11, 2020
Merged
Conversation
adds info for the agent_dvr integration
klaasnicolaas
added
the
new-integration
frenck
requested changes
Mar 11, 2020
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Thanks for the PR @ispysoftware!
I've reviewed it, and left some comments. Could you please take a look? Thanks! 👍
frenck
added
in-progress
Member
|
Oh please add a link to the parent PR in the openings post of this PR, since it is now unclear with PR in the codebase it belongs to. Thanks! 👍 |
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
ispysoftware
added a commit
to ispysoftware/brands
that referenced
this pull request
Mar 12, 2020
brand images for pull request home-assistant/home-assistant.io#12333
This was referenced Mar 12, 2020
Contributor
Author
|
Thanks @frenck I think i've covered everything - if not please let me know. |
frenck
reviewed
Mar 12, 2020
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
ha_release might need an update before merging this one in.
frenck
added
awaits-parent
frenck
previously approved these changes
Mar 12, 2020
fabaff
pushed a commit
to home-assistant/brands
that referenced
this pull request
Mar 18, 2020
brand images for pull request home-assistant/home-assistant.io#12333
frenck
requested changes
May 9, 2020
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Thanks for the PR @ispysoftware!
Left some small review comments, could you take a look? Thanks! 👍
frenck
added
in-progress
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
frenck
approved these changes
May 11, 2020
probot-home-assistant
Bot
removed
in-progress
techcoyangfeng
added a commit
to techcoyangfeng/brands
that referenced
this pull request
Aug 3, 2024
brand images for pull request home-assistant/home-assistant.io#12333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds info for the agent_dvr integration
brands pull request:
home-assistant/brands#50
Proposed change
adding an integration page for our agent_dvr integration
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.