Add agent_dvr integration by ispysoftware · Pull Request #32711 · home-assistant/core

ispysoftware · 2020-03-12T01:31:05Z

Proposed change

This adds an integration for Agent DVR, a windows 10 based DVR solution - https://www.ispyconnect.com/download.aspx

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: add agent_dvr home-assistant.io#12333

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum

homeassistant · 2020-03-12T01:31:08Z

Hi @ispysoftware,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant · 2020-03-12T01:35:27Z

Hi @ispysoftware,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant · 2020-03-12T01:45:08Z

Hi @ispysoftware,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

frenck · 2020-03-12T09:25:05Z

This is a really large PR.

A new integration should be limited to a single platform. As per:

https://developers.home-assistant.io/docs/creating_component_code_review#5-make-your-pull-request-as-small-as-possible

This makes reviewing easier to do, and in the end, everybody will be able to make progress quicker.

ispysoftware · 2020-03-12T13:11:20Z

@frenck I removed the code for binary sensors and the alarm control panel.

frenck · 2020-03-13T16:06:22Z

OK, in general, I think it looks good. However, a second reviewer has to take a look as well.

Last comment from me, would be the quality scale index you are trying to add: Gold (according to your initial openings post). In the current state of the integration, this level isn't reached.

See: https://developers.home-assistant.io/docs/integration_quality_scale_index/.

For example, tests for fetching data from the integration and controlling it are missing. Please make sure the integration matches the level selected. Another option would be to lower the quality scale and improve on it in future PR's.

ispysoftware · 2020-03-14T07:52:02Z

OK no probs, i changed it to silver. Thanks for reviewing it and being so responsive. It's much appreciated.

ispysoftware · 2020-03-17T01:17:06Z

Hey @frenck how do i get someone else to review it? I've made a load more updates to it but don't want to commit them until this is approved as then I guess you'd need to review it again...

frenck · 2020-03-17T14:01:18Z

By waiting for it. We have quite the workload, so it might take a moment.

ispysoftware · 2020-03-31T00:53:50Z

Hey @frenck, any update or estimated time frame? Does this usually take weeks/ months?

frenck · 2020-03-31T09:32:52Z

It is an opensource project, we rely on people investing their spare free time to contribute to this project. Sometimes this happens quickly, sometimes it takes a bit. Please, have some patience, thanks.

bdraco

Greetings @ispysoftware Thanks for submitting this PR. There are a few items that need adjustment.

bdraco

You might save yourself a lot of headache by installing the pre commit hooks that will do all the formatting for you. https://developers.home-assistant.io/docs/development_environment/#setting-up-virtual-environment

ispysoftware · 2020-04-15T07:37:49Z

I had it all setup with tox and black and everything working locally but had to revert 6 weeks worth of work to do these changes and now docker isn't working properly, my git repo is a mess, our zeroconf code is broken and im currently trying to bring all our test linux computers back to a point where all this old stuff was relevant.

ispysoftware · 2020-05-06T08:27:04Z

So what is this waiting on now?

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

…into agent

MartinHjelmare

Looks good! Just a couple of clean ups left.

MartinHjelmare

Great!

MartinHjelmare · 2020-05-08T11:13:36Z

@bdraco ok?

bdraco · 2020-05-08T13:52:24Z

@bdraco ok?

Will run though again on my next break from meetings

bdraco

Looks good. Thanks for jumping in @MartinHjelmare 🥇

probot-home-assistant Bot added new-integration integration: agent_dvr labels Mar 12, 2020

homeassistant added the cla-needed label Mar 12, 2020

homeassistant added cla-signed and removed cla-needed labels Mar 12, 2020

frenck reviewed Mar 12, 2020

View reviewed changes

Comment thread .coveragerc Outdated

frenck reviewed Mar 12, 2020

View reviewed changes

Comment thread homeassistant/components/agent_dvr/__init__.py Outdated

frenck reviewed Mar 12, 2020

View reviewed changes

Comment thread homeassistant/components/agent_dvr/__init__.py Outdated

frenck reviewed Mar 12, 2020

View reviewed changes

Comment thread homeassistant/components/agent_dvr/__init__.py Outdated

frenck reviewed Mar 13, 2020

View reviewed changes

Comment thread homeassistant/components/agent_dvr/__init__.py Outdated

frenck reviewed Mar 13, 2020

View reviewed changes

Comment thread homeassistant/components/agent_dvr/__init__.py Outdated

bdraco requested changes Apr 5, 2020

View reviewed changes

bdraco reviewed Apr 14, 2020

View reviewed changes

Comment thread homeassistant/components/agent_dvr/camera.py Outdated

bdraco reviewed Apr 14, 2020

View reviewed changes

Comment thread homeassistant/components/agent_dvr/helpers.py Outdated

bdraco reviewed Apr 14, 2020

View reviewed changes

Comment thread homeassistant/components/agent_dvr/services.yaml Outdated

bdraco reviewed Apr 14, 2020

View reviewed changes

Comment thread homeassistant/generated/zeroconf.py Outdated

bdraco reviewed Apr 15, 2020

View reviewed changes

Comment thread homeassistant/components/agent_dvr/__init__.py Outdated

MartinHjelmare requested changes May 6, 2020

View reviewed changes

MartinHjelmare removed the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label May 6, 2020

ispysoftware added 3 commits May 6, 2020 04:37

updates for review

2860005

add back in should poll again

7dbaecc

revert motion detection enabled flag in state attributes

675655b

ispysoftware requested a review from MartinHjelmare May 6, 2020 10:34

MartinHjelmare reviewed May 6, 2020

View reviewed changes

Comment thread homeassistant/components/agent_dvr/camera.py Outdated

Comment thread homeassistant/components/agent_dvr/camera.py Outdated

MartinHjelmare reviewed May 6, 2020

View reviewed changes

ispysoftware and others added 7 commits May 6, 2020 20:42

Update homeassistant/components/agent_dvr/camera.py

b338409

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Update homeassistant/components/agent_dvr/camera.py

f6328c4

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Update homeassistant/components/agent_dvr/camera.py

1224e7d

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Update homeassistant/components/agent_dvr/camera.py

d75d4ab

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Update homeassistant/components/agent_dvr/__init__.py

ed7d7e4

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Update homeassistant/components/agent_dvr/camera.py

e08c7ff

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Update homeassistant/components/agent_dvr/camera.py

51552d1

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

ispysoftware requested review from MartinHjelmare and bdraco May 7, 2020 00:28

ispysoftware and others added 4 commits May 8, 2020 08:21

Update homeassistant/components/agent_dvr/camera.py

e7d873c

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

add is_streaming

50f995e

Merge branch 'agent' of https://github.com/ispysoftware/home-assistant …

4b73d4c

…into agent

fix is_streaming bug, remove mp4 stream

8fba4c7

MartinHjelmare reviewed May 8, 2020

View reviewed changes

Comment thread homeassistant/components/agent_dvr/camera.py Outdated

Comment thread homeassistant/components/agent_dvr/manifest.json Outdated

cleanup

04cc7d0

MartinHjelmare approved these changes May 8, 2020

View reviewed changes

bdraco approved these changes May 8, 2020

View reviewed changes

bdraco merged commit 1be41b9 into home-assistant:dev May 8, 2020

lock Bot locked and limited conversation to collaborators May 21, 2020

Uh oh!

Conversation

ispysoftware commented Mar 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

homeassistant commented Mar 12, 2020

Uh oh!

homeassistant commented Mar 12, 2020

Uh oh!

homeassistant commented Mar 12, 2020

Uh oh!

frenck commented Mar 12, 2020

Uh oh!

ispysoftware commented Mar 12, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

frenck commented Mar 13, 2020

Uh oh!

ispysoftware commented Mar 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ispysoftware commented Mar 17, 2020

Uh oh!

frenck commented Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ispysoftware commented Mar 31, 2020

Uh oh!

frenck commented Mar 31, 2020

Uh oh!

bdraco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bdraco left a comment

Choose a reason for hiding this comment

Uh oh!

ispysoftware commented Apr 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ispysoftware commented May 6, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ispysoftware commented Mar 12, 2020 •

edited

Loading

ispysoftware commented Mar 14, 2020 •

edited

Loading

frenck commented Mar 17, 2020 •

edited

Loading

bdraco commented May 8, 2020 •

edited

Loading