Skip to content

Add Spotify retrive URI instructions#12012

Merged
frenck merged 4 commits into
home-assistant:currentfrom
starkillerOG:patch-11
Mar 21, 2020
Merged

Add Spotify retrive URI instructions#12012
frenck merged 4 commits into
home-assistant:currentfrom
starkillerOG:patch-11

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

@starkillerOG starkillerOG commented Feb 7, 2020

Proposed change

Add aditional instructions, after clearifing in the discord chat

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@starkillerOG starkillerOG requested a review from frenck as a code owner February 7, 2020 21:30
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Feb 7, 2020
Comment thread source/_integrations/spotify.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Feb 10, 2020
examle playlist: "Love Songs & Chill"
"Copy Spotify URI" gives: spotify:playlist:4QuJ2DbcTe7R8lzqfNXz7v
this works as `media_content_id`
"Copy Playlist Link" gives: https://open.spotify.com/playlist/4QuJ2DbcTe7R8lzqfNXz7v?si=cUKngvAER3KK3BHgNayOEA
this does not work as `media_content_id` and gives an error in HomeAssistant
However if you remove everthing after the question mark ? is does work:
https://open.spotify.com/playlist/4QuJ2DbcTe7R8lzqfNXz7v
Comment thread source/_integrations/spotify.markdown Outdated
starkillerOG and others added 2 commits February 15, 2020 16:28
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@starkillerOG
Copy link
Copy Markdown
Contributor Author

@frenck can this be merged, or schould I close this PR?

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 9, 2020

@starkillerOG It's still on the list. Please have a bit of patience, thanks.

@frenck frenck self-assigned this Mar 10, 2020
@frenck frenck removed their assignment Mar 21, 2020
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Mar 21, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG!

I've opened up home-assistant/core#33084 to address the issue from the code base end.

This PR can be merged in the current state 👍

@frenck frenck merged commit 66b1f77 into home-assistant:current Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants