Handle query and anchors in Spotify URI's#33084
Merged
Merged
Conversation
elupus
reviewed
Mar 21, 2020
Contributor
elupus
left a comment
There was a problem hiding this comment.
from yarl import URL
media_id = str(URL(media_id).with_query(None).with_fragment(None))
URLs really should never be parsed by hand. It's prone to breaking on some subtile thing.
Member
Author
|
Adjusted, I initially avoided that approach since a media_id doesn't have to be an URL, Spotify has many other identifiers. Apparently (after testing), Nevertheless, works, fine by me 🤷♂ |
balloob
approved these changes
Mar 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Using the
media_player.play_mediaservice on the Spotify integration works great, however, when using Spotify URL generated by their official client, a query string is added to the URL.The Spotify API itself, however, does not handle query strings or anchors in the URL's and just ignores the call.
This PR ensures the requested URI to play is cleaned from query strings and anchors.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: