Skip to content

Add service to Velbus#11892

Merged
frenck merged 4 commits into
home-assistant:nextfrom
brefra:Velbus_memo_text
Mar 14, 2020
Merged

Add service to Velbus#11892
frenck merged 4 commits into
home-assistant:nextfrom
brefra:Velbus_memo_text

Conversation

@brefra
Copy link
Copy Markdown
Contributor

@brefra brefra commented Jan 27, 2020 •
edited
Loading

Proposed change

Add description for both sync_clock and set_memo_text services of the Velbus integration.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Service for sync_clock is currently available in current release. The set_memo_text service will be available after applying the mentioned PR below.

  • Link to parent pull request in the codebase: #31222
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Jan 27, 2020
@brefra brefra mentioned this pull request Jan 27, 2020
Merged
20 tasks
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Jan 27, 2020
@brefra brefra changed the title Add service Add service to Velbus Jan 27, 2020
frenck
frenck requested changes Jan 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, @brefra!

Thanks for the PR. I've looked at it and left 2 small comments. Could you please take a look? Thanks! 👍

Comment thread source/_integrations/velbus.markdown
Comment thread source/_integrations/velbus.markdown Outdated
@frenck frenck added in-progress This PR/Issue is currently being worked on new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Jan 28, 2020
@brefra brefra removed their assignment Jan 28, 2020
@brefra brefra requested a review from frenck January 28, 2020 11:40
frenck
frenck approved these changes Jan 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Jan 28, 2020
@frenck frenck added the parent-merged The parent PR has been merged already label Mar 13, 2020
@frenck frenck merged commit 3cab6dd into home-assistant:next Mar 14, 2020
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Mar 14, 2020
guillempages pushed a commit to guillempages/home-assistant.io that referenced this pull request Mar 21, 2020
@brefra @frenck @guillempages
Add service to Velbus (home-assistant#11892)
de94cea 
* Add service description

* Change velbus to Velbus

Co-Authored-By: Franck Nijhof <frenck@frenck.nl>

* Add services heading

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@brefra brefra deleted the Velbus_memo_text branch April 29, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

Assignees

No one assigned

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brefra @frenck @klaasnicolaas