Skip to content

Add memo text service#31222

Merged
springstan merged 5 commits into
home-assistant:devfrom
brefra:Velbus_memo_text
Mar 13, 2020
Merged

Add memo text service#31222
springstan merged 5 commits into
home-assistant:devfrom
brefra:Velbus_memo_text

Conversation

@brefra
Copy link
Copy Markdown
Contributor

@brefra brefra commented Jan 27, 2020

Proposed change

Add service to set the memo text to be displayed at Velbus glass control modules like VMBGPO(D) and VMBELO

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • Updates the python-velbus lib to version 2.0.37 to support "Memo text" feature.
  • Link to documentation pull request: #11892

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @cereal2nd, mind taking a look at this pull request as its been labeled with a integration (velbus) you are listed as a codeowner for? Thanks!

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 28, 2020

Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️

Please, add your GitHub username to the manifest.json of this integration.

For more information about "code owners", see: Architecture Decision Record 0008: Code owners.

@springstan springstan added the dependency Pull requests marked as a dependency upgrade label Jan 31, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2020

Codecov Report

Merging #31222 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #31222   +/-   ##
=======================================
  Coverage   94.66%   94.67%           
=======================================
  Files         763      763           
  Lines       55114    55114           
=======================================
+ Hits        52176    52179    +3     
+ Misses       2938     2935    -3     
Impacted Files Coverage Δ
homeassistant/components/template/cover.py 97.71% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52fe132...f490d99. Read the comment docs.

@cereal2nd
Copy link
Copy Markdown
Contributor

can someone have a look at this one?
it would be good if we can get this merged

Comment thread homeassistant/components/velbus/__init__.py Outdated
Comment thread homeassistant/components/velbus/__init__.py Outdated
Comment thread homeassistant/components/velbus/const.py Outdated
Comment thread homeassistant/components/velbus/const.py Outdated
Comment thread homeassistant/components/velbus/__init__.py Outdated
@brefra brefra force-pushed the Velbus_memo_text branch from f490d99 to aa75949 Compare March 8, 2020 20:11
@brefra brefra changed the title Add memo text service and bump python-velbus to 2.0.37 Add memo text service Mar 8, 2020
Comment thread homeassistant/components/velbus/__init__.py Outdated
Comment thread homeassistant/components/velbus/__init__.py Outdated
Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@springstan springstan merged commit 31d1507 into home-assistant:dev Mar 13, 2020
@brefra brefra deleted the Velbus_memo_text branch March 13, 2020 19:42
@lock lock Bot locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency Pull requests marked as a dependency upgrade integration: velbus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants