Skip to content

QVR Pro documentation#11877

Merged
frenck merged 15 commits into
home-assistant:nextfrom
oblogic7:qvrpro
Mar 4, 2020
Merged

QVR Pro documentation#11877
frenck merged 15 commits into
home-assistant:nextfrom
oblogic7:qvrpro

Conversation

@oblogic7
Copy link
Copy Markdown
Contributor

@oblogic7 oblogic7 commented Jan 26, 2020

Proposed change

Adds documentation for new QVR Pro integration

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Jan 26, 2020
@klaasnicolaas
Copy link
Copy Markdown
Member

klaasnicolaas commented Jan 26, 2020

Please merge the documentation to one single file qvrpro.markdown and put it in the _integrations folder.

@klaasnicolaas klaasnicolaas added in-progress This PR/Issue is currently being worked on new-integration This PR adds documentation for a new Home Assistant integration labels Jan 26, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 20, 2020

It is not just the renaming, but the whole page.

It seems like you are using a very very old format (over a year old at least).
Please take a look at other pages, the way we make headers and things we put into the frontmatter changed quite a bit.

Please update this page to match the rest of our documentation.

@oblogic7
Copy link
Copy Markdown
Contributor Author

Yes, I started this integration over a year ago and the working branch was rather stale. I believe everything should be current now.

Comment thread source/_integrations/qvr_pro.markdown Outdated
Comment thread source/_integrations/qvr_pro.markdown Outdated
Comment thread source/_integrations/qvr_pro.markdown Outdated
Comment thread source/_integrations/qvr_pro.markdown Outdated
Comment thread source/_integrations/qvr_pro.markdown Outdated
oblogic7 and others added 6 commits February 20, 2020 10:29
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
… into qvrpro

� Conflicts:
�	source/_integrations/qvr_pro.markdown
frenck
frenck previously approved these changes Feb 20, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Feb 20, 2020
@MartinHjelmare MartinHjelmare added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Mar 3, 2020
@frenck frenck merged commit 4b3ba45 into home-assistant:next Mar 4, 2020
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants