Add QVR Pro integration by oblogic7 · Pull Request #31173 · home-assistant/core

oblogic7 · 2020-01-26T04:02:40Z

Proposed change

Allows QVR Pro channels to be added as cameras to Home Assistant. Also adds two services for starting and stopping recording of a specified channel in QVR Pro.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example entry for `configuration.yaml`:

# Example configuration.yaml
qvrpro:
  host: 192.168.1.102
  username: pyqvruser
  password: password
  exclude_channels: 2,5,6

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: QVR Pro documentation home-assistant.io#11877

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum

…into qvrpro

… channel name. Update service argument.

…into qvrpro

oblogic7 · 2020-01-26T04:14:07Z

I do not see any reason why the pipeline is failing on CODEOWNERS file. Running python3 -m script.hassfest does not result in any changes. How can I figure out why it is complaining about that file?

MartinHjelmare · 2020-01-26T22:38:04Z

Codeowners file should update since the codeowners item is set in manifest.json.

I'd try rebasing on latest dev branch and then run the hassfest script again.

…into qvrpro

Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>

…nto qvrpro � Conflicts: � homeassistant/components/qvrpro/__init__.py

MartinHjelmare

Looks great! Just a couple of comments.

MartinHjelmare · 2020-02-20T07:39:20Z

Please update the config example in the PR description. The camera platform shouldn't be included.

…streaming

oblogic7 · 2020-02-20T16:33:56Z

Updated to handle an error condition I just found relating to live streaming. Should be GTG if no changes are required for that update.

codecov · 2020-02-20T17:08:20Z

Codecov Report

Merging #31173 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev   #31173      +/-   ##
==========================================
+ Coverage   94.71%   94.72%   +0.01%     
==========================================
  Files         766      767       +1     
  Lines       55568    55483      -85     
==========================================
- Hits        52630    52556      -74     
+ Misses       2938     2927      -11

Impacted Files	Coverage Δ
homeassistant/components/template/binary_sensor.py	`94.35% <ø> (ø)`	⬆️
homeassistant/components/zha/core/__init__.py	`100% <ø> (ø)`	⬆️
homeassistant/components/flux/switch.py	`95.37% <ø> (ø)`	⬆️
homeassistant/components/zha/core/group.py	`69.04% <ø> (ø)`	⬆️
homeassistant/components/zha/core/discovery.py	`98.79% <ø> (+2.53%)`	⬆️
homeassistant/components/geo_rss_events/sensor.py	`100% <ø> (ø)`	⬆️
...assistant/components/mqtt/light/schema_template.py	`80.18% <ø> (ø)`	⬆️
homeassistant/components/uk_transport/sensor.py	`93.47% <ø> (-0.73%)`	⬇️
...omeassistant/components/mqtt/light/schema_basic.py	`93.35% <ø> (ø)`	⬆️
homeassistant/components/mqtt/light/__init__.py	`100% <ø> (ø)`	⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e5fc2...e7ee71e. Read the comment docs.

…into qvrpro

oblogic7 · 2020-02-21T14:26:34Z

I ran into an authentication bug with the QVR API and have opened an issue with QNAP. I decided it is better to disable support for the stream component until this is resolved. I don't know how long it will take for them to resolve, so we can go ahead and merge the integration when you are ready. LMK if any other changes are needed.

oblogic7 · 2020-03-02T19:17:13Z

Anything else needed for this?

oblogic7 added 9 commits February 15, 2019 21:10

Initial working commit

b5b509d

Create const file. Load camera from component.

9107f4c

Handle failed authentication. Bump library version.

04427a9

Remove line break

74b39c4

Camera attributes and recording services

37cd298

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

e88efcc

…into qvrpro

Add services, manifest, constant update, and exclude_channels. Prefix…

d2fe4f6

… channel name. Update service argument.

Update codeowners

af19a6e

Update coveragerc

3e52766

homeassistant added the cla-signed label Jan 26, 2020

probot-home-assistant Bot added new-integration integration: qvrpro labels Jan 26, 2020

oblogic7 mentioned this pull request Jan 26, 2020

QVR Pro documentation home-assistant/home-assistant.io#11877

Merged

7 tasks

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

c70fc28

…into qvrpro

oblogic7 added 4 commits January 26, 2020 16:41

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

a003f5c

…into qvrpro

Remove codeowners line

f30e36a

Update codeowners again from python3 -m script.hassfest

d8bc8dc

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

79e2b44

…into qvrpro

springstan changed the title ~~QVR Pro~~ Add QVR Pro integration Jan 31, 2020

springstan reviewed Feb 3, 2020

View reviewed changes

Comment thread homeassistant/components/qvrpro/__init__.py Outdated

Comment thread homeassistant/components/qvrpro/__init__.py Outdated

Comment thread homeassistant/components/qvrpro/__init__.py Outdated

oblogic7 and others added 4 commits February 3, 2020 17:23

Update homeassistant/components/qvrpro/__init__.py

0202d8a

Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>

Requested changes

99d067c

Merge branch 'qvrpro' of https://github.com/oblogic7/home-assistant i…

15e278c

…nto qvrpro � Conflicts: � homeassistant/components/qvrpro/__init__.py

Fix typo

d337632

springstan reviewed Feb 6, 2020

View reviewed changes

Comment thread homeassistant/components/qvrpro/__init__.py Outdated

Update to use exception. Bump library version.

1bbd804

springstan reviewed Feb 7, 2020

View reviewed changes

Comment thread homeassistant/components/qvrpro/camera.py Outdated

Comment thread homeassistant/components/qvrpro/__init__.py

Support stream component

d5bc4e8

oblogic7 added 5 commits February 19, 2020 12:12

Partial requested changes

4accc26

Update coveragerc and codeowners

3b3f65b

Move constants to const file. Add SHORT_NAME

c1da03b

Add conf variable

366f535

Use camera domain

90a27e9

springstan reviewed Feb 19, 2020

View reviewed changes

Comment thread homeassistant/components/qvr_pro/const.py Outdated

Comment thread homeassistant/components/qvr_pro/__init__.py Outdated

Comment thread homeassistant/components/qvr_pro/__init__.py Outdated

More requested changes

bb63e68

springstan reviewed Feb 19, 2020

View reviewed changes

Requested changes

6f887ca

MartinHjelmare requested changes Feb 20, 2020

View reviewed changes

Comment thread homeassistant/components/qvr_pro/camera.py Outdated

Comment thread homeassistant/components/qvr_pro/camera.py Outdated

Requested changes

a0f1d29

MartinHjelmare approved these changes Feb 20, 2020

View reviewed changes

oblogic7 added 3 commits February 20, 2020 08:38

Merge remote-tracking branch 'upstream/dev' into qvrpro

33bb74d

Update prefix

0d476b1

Handle error condition when camera is not configured to support live …

afe1929

…streaming

MartinHjelmare requested changes Feb 20, 2020

View reviewed changes

Comment thread homeassistant/components/qvr_pro/camera.py Outdated

springstan reviewed Feb 20, 2020

View reviewed changes

Comment thread homeassistant/components/qvr_pro/camera.py Outdated

oblogic7 added 2 commits February 21, 2020 08:20

Move method to camera setup. Disable stream component support.

31e5fc2

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

e072e6d

…into qvrpro

MartinHjelmare approved these changes Feb 21, 2020

View reviewed changes

springstan approved these changes Feb 21, 2020

View reviewed changes

Comment thread homeassistant/components/qvr_pro/camera.py Outdated

Move auth string to library to prevent private member access

e7ee71e

MartinHjelmare approved these changes Mar 3, 2020

View reviewed changes

MartinHjelmare merged commit ee7ce47 into home-assistant:dev Mar 3, 2020

lock Bot locked and limited conversation to collaborators Mar 10, 2020

Uh oh!

Conversation

oblogic7 commented Jan 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Example entry for configuration.yaml:

Additional information

Checklist

Uh oh!

oblogic7 commented Jan 26, 2020

Uh oh!

MartinHjelmare commented Jan 26, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare commented Feb 20, 2020

Uh oh!

oblogic7 commented Feb 20, 2020

Uh oh!

Uh oh!

codecov Bot commented Feb 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

oblogic7 commented Feb 21, 2020

Uh oh!

Uh oh!

oblogic7 commented Mar 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oblogic7 commented Jan 26, 2020 •

edited

Loading

Example entry for `configuration.yaml`:

codecov Bot commented Feb 20, 2020 •

edited

Loading