Skip to content

Update netatmo.markdown#11770

Merged
fabaff merged 1 commit into
nextfrom
cgtobi-refactor-netatmo
Jan 20, 2020
Merged

Update netatmo.markdown#11770
fabaff merged 1 commit into
nextfrom
cgtobi-refactor-netatmo

Conversation

@cgtobi
Copy link
Copy Markdown
Contributor

@cgtobi cgtobi commented Jan 16, 2020

Description:
Remove documentation about (temporarily) removed features and configuration options.

Pull request in home-assistant (if applicable): home-assistant/core#29851

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

Remove documentation about (temporarily) removed features and configuration options.
@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Jan 16, 2020
@klaasnicolaas klaasnicolaas added the parent-merged The parent PR has been merged already label Jan 16, 2020
@fabaff fabaff merged commit 8007d4c into next Jan 20, 2020
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Jan 20, 2020
@delete-merged-branch delete-merged-branch Bot deleted the cgtobi-refactor-netatmo branch January 20, 2020 08:30
ochlocracy pushed a commit to ochlocracy/home-assistant.io that referenced this pull request Jan 22, 2020
Remove documentation about (temporarily) removed features and configuration options.
client_secret:
description: The `client secret` from your Netatmo app.
required: true
type: integer
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm late to the party, but I'm pretty confused from the docs.

How can this ever be an integer? It's always be a string. It's even a string in the provided screenshot?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rugaard well spotted. Thanks. Do you mind fixing it and opening a PR?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done #12009 👍

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants