Refactor Netatmo integration#29851
Merged
MartinHjelmare merged 58 commits intoJan 11, 2020
Merged
Conversation
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
balloob
reviewed
Dec 12, 2019
c069070 to
62b6bfd
Compare
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
A couple of lines are missing coverage in the config flow.
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Final comment I think.
Contributor
Author
|
Copy and pasting your suggestions wasn't that hard. 😉 |
Member
|
I missed a docs PR. Please link it in the description. |
Contributor
Author
|
That is true, I’ll fix that ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
A lot
client id and secretare required, no need to pass your username and password anymoreset_schedulenow requires the name of the homeUser with existing configuration have to remove/update that and run the config flow dialogue to get their sensors/etc. back using the
configuration.yamloption.Description:
set_schedule, now requires the name of the homeRelated issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11770
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: