Skip to content

Refactor Netatmo integration#29851

Merged
MartinHjelmare merged 58 commits into
home-assistant:devfrom
cgtobi:refactor_netatmo_integration
Jan 11, 2020
Merged

Refactor Netatmo integration#29851
MartinHjelmare merged 58 commits into
home-assistant:devfrom
cgtobi:refactor_netatmo_integration

Conversation

@cgtobi
Copy link
Copy Markdown
Contributor

@cgtobi cgtobi commented Dec 11, 2019

Breaking Change:

A lot

  • for authentication only client id and secret are required, no need to pass your username and password anymore
  • public weather sensors are removed and will be added back in a separate PR
  • Service set_schedule now requires the name of the home
  • webhooks are removed and will be added back in a separate PR
  • Services to toggle the light/set it to auto have been removed until implemented in pyatmo

User with existing configuration have to remove/update that and run the config flow dialogue to get their sensors/etc. back using the configuration.yaml option.

Description:

  • Implements OAuth2 account linking
  • Fixed set_schedule, now requires the name of the home

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11770

Example entry for configuration.yaml (if applicable):

netatmo:
  client_id: your_client_id
  client_secret: your_client_secret

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/netatmo/__init__.py Outdated
Comment thread homeassistant/components/netatmo/__init__.py Outdated
Comment thread homeassistant/components/netatmo/__init__.py Outdated
Comment thread homeassistant/components/netatmo/__init__.py Outdated
Comment thread homeassistant/components/netatmo/binary_sensor.py Outdated
Comment thread homeassistant/components/netatmo/binary_sensor.py Outdated
Comment thread homeassistant/components/netatmo/binary_sensor.py Outdated
Comment thread homeassistant/components/netatmo/binary_sensor.py Outdated
Comment thread homeassistant/components/netatmo/binary_sensor.py Outdated
Comment thread homeassistant/components/netatmo/binary_sensor.py Outdated
Comment thread homeassistant/components/netatmo/binary_sensor.py Outdated
Comment thread homeassistant/components/netatmo/binary_sensor.py Outdated
Comment thread homeassistant/components/netatmo/camera.py Outdated
Comment thread homeassistant/components/netatmo/camera.py Outdated
Comment thread homeassistant/components/netatmo/camera.py Outdated
Comment thread homeassistant/components/netatmo/camera.py Outdated
Comment thread homeassistant/components/netatmo/camera.py Outdated
Comment thread homeassistant/components/netatmo/camera.py Outdated
Comment thread homeassistant/components/netatmo/camera.py Outdated
Comment thread homeassistant/components/netatmo/camera.py Outdated
Comment thread homeassistant/components/netatmo/camera.py Outdated
Comment thread homeassistant/components/netatmo/climate.py Outdated
Comment thread homeassistant/components/netatmo/climate.py Outdated
Comment thread homeassistant/components/netatmo/climate.py Outdated
@cgtobi cgtobi force-pushed the refactor_netatmo_integration branch from c069070 to 62b6bfd Compare January 9, 2020 21:34
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread .coveragerc Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comment I think.

Comment thread tests/components/netatmo/test_config_flow.py Outdated
Comment thread tests/components/netatmo/test_config_flow.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cgtobi
Copy link
Copy Markdown
Contributor Author

cgtobi commented Jan 10, 2020

Copy and pasting your suggestions wasn't that hard. 😉

@MartinHjelmare MartinHjelmare merged commit e793ed9 into home-assistant:dev Jan 11, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

I missed a docs PR. Please link it in the description.

@cgtobi
Copy link
Copy Markdown
Contributor Author

cgtobi commented Jan 11, 2020

That is true, I’ll fix that ASAP.

@lock lock Bot locked and limited conversation to collaborators Jan 12, 2020
@cgtobi cgtobi deleted the refactor_netatmo_integration branch August 25, 2020 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants