Update nederlandse_spoorwegen.markdown#11700
Conversation
Changes reflect this [PR](home-assistant/core#30611)
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
|
Thanks for the tweak and your time reviewing this PR! |
Co-Authored-By: Anders Melchiorsen <amelchio@nogoto.net>
|
@YarmoM the API you mentioned in this PR might be outdated before this gets merged into master. You mentioned that the
Source: https://apiportal.ns.nl/products/PublicNsApi So, I'm not sure whether or not this is going to work after that date. Just thought I'd mention this. |
|
@kevintuhumury Thanks a bunch for mentioning this! I hadn't realized this change was about to happen. So for my understanding, I need to point to "NS app" product and then "Reisinformatie" API? |
|
@YarmoM I'm not completely sure. I haven't looked into the API's themselves. I was going through your updated documentation as I want to use the integration myself. So, I went to the API portal and noticed the mention of them closing the API. It does look like you should use the 'NS app' product, but I'm unsure whether the 'Reisinformatie' API provides the same or more data. |
* Update nederlandse_spoorwegen.markdown Changes reflect this [PR](home-assistant/core#30611) * ✏️ Tweak * Fixed typo Co-Authored-By: Anders Melchiorsen <amelchio@nogoto.net> Co-authored-by: Franck Nijhof <frenck@frenck.nl> Co-authored-by: Anders Melchiorsen <amelchio@nogoto.net>
Description:
The NS API has recently changed and this documentation update reflects the changes made in the component codebase.
Pull request in home-assistant (if applicable): home-assistant/core#30599
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.