Skip to content

Update nederlandse_spoorwegen.markdown#11700

Merged
frenck merged 3 commits into
home-assistant:nextfrom
YarmoM:patch-1
Jan 13, 2020
Merged

Update nederlandse_spoorwegen.markdown#11700
frenck merged 3 commits into
home-assistant:nextfrom
YarmoM:patch-1

Conversation

@YarmoM
Copy link
Copy Markdown
Contributor

@YarmoM YarmoM commented Jan 10, 2020

Description:
The NS API has recently changed and this documentation update reflects the changes made in the component codebase.

Pull request in home-assistant (if applicable): home-assistant/core#30599

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Jan 10, 2020
frenck
frenck previously approved these changes Jan 12, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Jan 12, 2020
@YarmoM
Copy link
Copy Markdown
Contributor Author

YarmoM commented Jan 12, 2020

Thanks for the tweak and your time reviewing this PR!

@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Jan 12, 2020
Comment thread source/_integrations/nederlandse_spoorwegen.markdown Outdated
Co-Authored-By: Anders Melchiorsen <amelchio@nogoto.net>
@frenck frenck merged commit a06e7a5 into home-assistant:next Jan 13, 2020
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Jan 13, 2020
@kevintuhumury
Copy link
Copy Markdown
Contributor

@YarmoM the API you mentioned in this PR might be outdated before this gets merged into master. You mentioned that the RetrieveTripInformationPublicAPI API should be used. Looking at the corresponding page it mentions the following:

Per the 31st of january only the price API will be available here. Please go to the Ns app Product on this website for using the other API's that are available. Only the Price API will work after the 31st of january!

Source: https://apiportal.ns.nl/products/PublicNsApi

So, I'm not sure whether or not this is going to work after that date. Just thought I'd mention this.

@YarmoM
Copy link
Copy Markdown
Contributor Author

YarmoM commented Jan 19, 2020

@kevintuhumury Thanks a bunch for mentioning this! I hadn't realized this change was about to happen.

So for my understanding, I need to point to "NS app" product and then "Reisinformatie" API?

@kevintuhumury
Copy link
Copy Markdown
Contributor

@YarmoM I'm not completely sure. I haven't looked into the API's themselves. I was going through your updated documentation as I want to use the integration myself. So, I went to the API portal and noticed the mention of them closing the API.

It does look like you should use the 'NS app' product, but I'm unsure whether the 'Reisinformatie' API provides the same or more data.

ochlocracy pushed a commit to ochlocracy/home-assistant.io that referenced this pull request Jan 22, 2020
* Update nederlandse_spoorwegen.markdown

Changes reflect this [PR](home-assistant/core#30611)

* ✏️ Tweak

* Fixed typo

Co-Authored-By: Anders Melchiorsen <amelchio@nogoto.net>

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Anders Melchiorsen <amelchio@nogoto.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants