Skip to content

Add support for Dyson TP06 fan#30611

Merged
springstan merged 5 commits into
home-assistant:devfrom
etheralm:TP06
Jan 11, 2020
Merged

Add support for Dyson TP06 fan#30611
springstan merged 5 commits into
home-assistant:devfrom
etheralm:TP06

Conversation

@etheralm
Copy link
Copy Markdown
Contributor

@etheralm etheralm commented Jan 9, 2020

Description:

The new dyson fan with model TP06 uses the same product number as TP04, but it has a combined filter and reports "INV" as carbon filter state instead of a numerical value. This PR fixes this issue.

Related issue (if applicable): fixes etheralm/libpurecool#8 fixes #30340

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11689

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@itewk
Copy link
Copy Markdown
Contributor

itewk commented Jan 9, 2020

yippy!

@springstan
Copy link
Copy Markdown
Member

@etheralm please adjust the docs respectively to this change :)

@etheralm
Copy link
Copy Markdown
Contributor Author

etheralm commented Jan 9, 2020

@springstan, I had a quick look at the docs, but I missed the part at the end with the exact models. Thanks for the hint.

@etheralm
Copy link
Copy Markdown
Contributor Author

etheralm commented Jan 9, 2020

Docs updated.

Comment thread tests/components/dyson/test_fan.py
@springstan springstan merged commit 5ffbf55 into home-assistant:dev Jan 11, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disdingwish between TP04 and TP06 Dyson TP06 not working

4 participants