Lovelace: add confirmation action#10834
Merged
Merged
Conversation
probot-home-assistant
Bot
added
has-parent
iantrich
added
the
new-feature
Member
Author
|
Is there a better way to do this? Repeating the same lines throughout all these files seems prone to failure and makes maintenance a chore. |
frenck
requested changes
Oct 17, 2019
| required: false | ||
| description: "Present a confirmation dialog to confirm the action. See `confirmation` object below" | ||
| type: [boolean, map] | ||
| default: "false" |
Member
There was a problem hiding this comment.
You don't have to quote booleans ;)
Member
Author
There was a problem hiding this comment.
All other defaults in this file had quotes, so I followed the trend 🤷♂
frenck
approved these changes
Oct 20, 2019
probot-home-assistant
Bot
removed
the
parent-merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
home-assistant/frontend#4006
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.